public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Javi Merino <javi.merino@arm.com>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: "rui.zhang@intel.com" <rui.zhang@intel.com>,
	"edubezval@gmail.com" <edubezval@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Andreas Ruprecht <rupran@einserver.de>,
	Paul Bolle <pebolle@tiscali.nl>
Subject: Re: select on undefined THERMAL_POWER_ACTOR
Date: Wed, 4 Mar 2015 17:46:24 +0000	[thread overview]
Message-ID: <20150304174623.GA14216@e104805> (raw)
In-Reply-To: <CAD3Xx4KK5LGJSPHvsnX36EUB-T6j_6RgGw=oQ+gZyP8RBhC1=Q@mail.gmail.com>

Hi Valentin,

On Wed, Mar 04, 2015 at 01:19:25PM +0000, Valentin Rothberg wrote:
> your commit 8754d5115693 ("thermal: introduce the Power Allocator
> governor") is included in today's linux-next tree (i.e.,
> next-20150304).
> 
> This patch adds a select on the Kconfig symbol THERMAL_POWER_ACTOR.
> However, THERMAL_POWER_ACTOR is not defined so that this select is a
> NOOP.
> 
> @@ -99,6 +107,13 @@ config THERMAL_GOV_USER_SPACE
>         help
>           Enable this to let the user space manage the platform thermals.
> 
> +config THERMAL_GOV_POWER_ALLOCATOR
> +       bool "Power allocator thermal governor"
> +       select THERMAL_POWER_ACTOR
> 
> Is there a patch queued somewhere that adds this Kconfig symbol?

No there isn't, it's a leftover from a previous version of the
patches.  I'll send a patch to remove it.

Thanks for reporting it!
Javi

>                                                                   I
> detected the issue by running undertaker-checkpatch from the
> Undertaker tool suite (undertaker.cs.fau.de).
> 
> Kind regards,
>  Valentin


      reply	other threads:[~2015-03-04 17:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 13:19 select on undefined THERMAL_POWER_ACTOR Valentin Rothberg
2015-03-04 17:46 ` Javi Merino [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150304174623.GA14216@e104805 \
    --to=javi.merino@arm.com \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=rui.zhang@intel.com \
    --cc=rupran@einserver.de \
    --cc=valentinrothberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox