From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932835AbbCDRq3 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Mar 2015 12:46:29 -0500
Received: from service87.mimecast.com ([91.220.42.44]:55791 "EHLO
	service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759210AbbCDRq1 convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Mar 2015 12:46:27 -0500
Date: Wed, 4 Mar 2015 17:46:24 +0000
From: Javi Merino <javi.merino@arm.com>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: "rui.zhang@intel.com" <rui.zhang@intel.com>,
        "edubezval@gmail.com" <edubezval@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        Andreas Ruprecht <rupran@einserver.de>,
        Paul Bolle <pebolle@tiscali.nl>
Subject: Re: select on undefined THERMAL_POWER_ACTOR
Message-ID: <20150304174623.GA14216@e104805>
References: <CAD3Xx4KK5LGJSPHvsnX36EUB-T6j_6RgGw=oQ+gZyP8RBhC1=Q@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAD3Xx4KK5LGJSPHvsnX36EUB-T6j_6RgGw=oQ+gZyP8RBhC1=Q@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-OriginalArrivalTime: 04 Mar 2015 17:46:24.0698 (UTC) FILETIME=[223019A0:01D056A3]
X-MC-Unique: 115030417462503401
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Valentin,

On Wed, Mar 04, 2015 at 01:19:25PM +0000, Valentin Rothberg wrote:
> your commit 8754d5115693 ("thermal: introduce the Power Allocator
> governor") is included in today's linux-next tree (i.e.,
> next-20150304).
> 
> This patch adds a select on the Kconfig symbol THERMAL_POWER_ACTOR.
> However, THERMAL_POWER_ACTOR is not defined so that this select is a
> NOOP.
> 
> @@ -99,6 +107,13 @@ config THERMAL_GOV_USER_SPACE
>         help
>           Enable this to let the user space manage the platform thermals.
> 
> +config THERMAL_GOV_POWER_ALLOCATOR
> +       bool "Power allocator thermal governor"
> +       select THERMAL_POWER_ACTOR
> 
> Is there a patch queued somewhere that adds this Kconfig symbol?

No there isn't, it's a leftover from a previous version of the
patches.  I'll send a patch to remove it.

Thanks for reporting it!
Javi

>                                                                   I
> detected the issue by running undertaker-checkpatch from the
> Undertaker tool suite (undertaker.cs.fau.de).
> 
> Kind regards,
>  Valentin