* select on undefined THERMAL_POWER_ACTOR
@ 2015-03-04 13:19 Valentin Rothberg
2015-03-04 17:46 ` Javi Merino
0 siblings, 1 reply; 2+ messages in thread
From: Valentin Rothberg @ 2015-03-04 13:19 UTC (permalink / raw)
To: javi.merino, rui.zhang, edubezval, linux-kernel, linux-pm,
Andreas Ruprecht, Paul Bolle, Valentin Rothberg
Hi Javi,
your commit 8754d5115693 ("thermal: introduce the Power Allocator
governor") is included in today's linux-next tree (i.e.,
next-20150304).
This patch adds a select on the Kconfig symbol THERMAL_POWER_ACTOR.
However, THERMAL_POWER_ACTOR is not defined so that this select is a
NOOP.
@@ -99,6 +107,13 @@ config THERMAL_GOV_USER_SPACE
help
Enable this to let the user space manage the platform thermals.
+config THERMAL_GOV_POWER_ALLOCATOR
+ bool "Power allocator thermal governor"
+ select THERMAL_POWER_ACTOR
Is there a patch queued somewhere that adds this Kconfig symbol? I
detected the issue by running undertaker-checkpatch from the
Undertaker tool suite (undertaker.cs.fau.de).
Kind regards,
Valentin
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: select on undefined THERMAL_POWER_ACTOR
2015-03-04 13:19 select on undefined THERMAL_POWER_ACTOR Valentin Rothberg
@ 2015-03-04 17:46 ` Javi Merino
0 siblings, 0 replies; 2+ messages in thread
From: Javi Merino @ 2015-03-04 17:46 UTC (permalink / raw)
To: Valentin Rothberg
Cc: rui.zhang@intel.com, edubezval@gmail.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Andreas Ruprecht, Paul Bolle
Hi Valentin,
On Wed, Mar 04, 2015 at 01:19:25PM +0000, Valentin Rothberg wrote:
> your commit 8754d5115693 ("thermal: introduce the Power Allocator
> governor") is included in today's linux-next tree (i.e.,
> next-20150304).
>
> This patch adds a select on the Kconfig symbol THERMAL_POWER_ACTOR.
> However, THERMAL_POWER_ACTOR is not defined so that this select is a
> NOOP.
>
> @@ -99,6 +107,13 @@ config THERMAL_GOV_USER_SPACE
> help
> Enable this to let the user space manage the platform thermals.
>
> +config THERMAL_GOV_POWER_ALLOCATOR
> + bool "Power allocator thermal governor"
> + select THERMAL_POWER_ACTOR
>
> Is there a patch queued somewhere that adds this Kconfig symbol?
No there isn't, it's a leftover from a previous version of the
patches. I'll send a patch to remove it.
Thanks for reporting it!
Javi
> I
> detected the issue by running undertaker-checkpatch from the
> Undertaker tool suite (undertaker.cs.fau.de).
>
> Kind regards,
> Valentin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-04 17:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-04 13:19 select on undefined THERMAL_POWER_ACTOR Valentin Rothberg
2015-03-04 17:46 ` Javi Merino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox