From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933336AbbCDRtI (ORCPT ); Wed, 4 Mar 2015 12:49:08 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:50511 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932770AbbCDRtG (ORCPT ); Wed, 4 Mar 2015 12:49:06 -0500 Date: Wed, 4 Mar 2015 09:48:33 -0800 From: Guenter Roeck To: Alexandre Belloni Cc: Nicolas Ferre , Daniel Lezcano , Boris Brezillon , Jean-Christophe Plagniol-Villard , Thomas Gleixner , Lee Jones , Wim Van Sebroeck , Sebastian Reichel , Dmitry Eremin-Solenikov , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v3 3/9] watchdog: at91rm9200: use the system timer syscon Message-ID: <20150304174826.GA5568@roeck-us.net> References: <1425478897-27322-1-git-send-email-alexandre.belloni@free-electrons.com> <1425478897-27322-4-git-send-email-alexandre.belloni@free-electrons.com> <54F71C07.6070204@roeck-us.net> <20150304150815.GG3989@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150304150815.GG3989@piout.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020201.54F74591.0076,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 11 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2015 at 04:08:15PM +0100, Alexandre Belloni wrote: > On 04/03/2015 at 06:51:51 -0800, Guenter Roeck wrote : > > >@@ -267,7 +276,7 @@ static struct platform_driver at91wdt_driver = { > > > .suspend = at91wdt_suspend, > > > .resume = at91wdt_resume, > > > .driver = { > > >- .name = "at91_wdt", > > >+ .name = "atmel_st_watchdog", > > > > If you change the driver name you also need to change the MODULE_ALIAS > > a few lines down. > > > > But why change it in the first place ? Maybe that was discussed somewhere, > > but not here where it belongs, and not in patch 0/9 either. > > > > That's because it conflicts with drivers/watchdog/at91sam9_wdt.c > You still have to update MODULE_ALIAS (or drop it if it is not needed anymore). Guenter > I'm not sure that is relevant anymore as they will only be probed using > DT now. > > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com