From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760128AbbCDTo3 (ORCPT ); Wed, 4 Mar 2015 14:44:29 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:47571 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759414AbbCDTo0 (ORCPT ); Wed, 4 Mar 2015 14:44:26 -0500 Date: Wed, 4 Mar 2015 13:44:24 -0600 From: Andy Gross To: Vinod Koul Cc: Stanimir Varbanov , Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] dmaengine: bam-dma: fill slave directions bit mask Message-ID: <20150304194424.GA18054@qualcomm.com> References: <1425482710-23052-1-git-send-email-stanimir.varbanov@linaro.org> <20150304160213.GT2613@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150304160213.GT2613@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2015 at 09:32:13PM +0530, Vinod Koul wrote: > On Wed, Mar 04, 2015 at 05:25:10PM +0200, Stanimir Varbanov wrote: > > This will avoid warning during async device registration. > > > > Signed-off-by: Stanimir Varbanov > > --- > > drivers/dma/qcom_bam_dma.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/dma/qcom_bam_dma.c b/drivers/dma/qcom_bam_dma.c > > index c3113e3..cc9e5ee 100644 > > --- a/drivers/dma/qcom_bam_dma.c > > +++ b/drivers/dma/qcom_bam_dma.c > > @@ -1143,6 +1143,7 @@ static int bam_dma_probe(struct platform_device *pdev) > > dma_cap_set(DMA_SLAVE, bdev->common.cap_mask); > > > > /* initialize dmaengine apis */ > > + bdev->common.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV); > > bdev->common.device_alloc_chan_resources = bam_alloc_chan; > > bdev->common.device_free_chan_resources = bam_free_chan; > > bdev->common.device_prep_slave_sg = bam_prep_slave_sg; > You need to fill other fields, src/dstn_addr_widths and > residue_granularity... Add segment granularity for BAM, as we can read the current completed segment. bdev->common.residue_granularity = DMA_RESIDUE_GRANULARITY_SEGMENT; Use DMA_SLAVE_BUSWIDTH_4_BYTES for the src/dst addr width: bdev->common.src_addr_widths = DMA_SLAVE_BUSWIDTH_4_BYTES; bdev->common.dst_addr_widths = DMA_SLAVE_BUSWIDTH_4_BYTES; -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project