From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758456AbbCDUWd (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Mar 2015 15:22:33 -0500
Received: from mail-wg0-f43.google.com ([74.125.82.43]:41445 "EHLO
	mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753968AbbCDUWc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Mar 2015 15:22:32 -0500
Date: Wed, 4 Mar 2015 21:22:27 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: x86-ml <x86@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Andy Lutomirski <luto@amacapital.net>,
        lkml <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [GIT PULL] x86/alternatives padding
Message-ID: <20150304202227.GA6826@gmail.com>
References: <20150303170632.GE25768@pd.tnic>
 <20150304073221.GD22014@gmail.com>
 <20150304112206.GB3516@pd.tnic>
 <20150304114151.GD3516@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150304114151.GD3516@pd.tnic>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Borislav Petkov <bp@alien8.de> wrote:

> On Wed, Mar 04, 2015 at 12:22:06PM +0100, Borislav Petkov wrote:
> > Well, kernel image doesn't change while vmlinux shows only a very small
> > .text increase of about 2K. I'm not sure yet why that happens though
> > because it shouldn't be the padding. Because we will have to do it
> > anyway, this patchset makes it automatic instead of by-hand, so to
> > speak.
> > 
> > Let me bisect it and see which patch adds the increase.
> 
> Doh, of course. I've added u8 padlen to the alternative instruction
> entry struct. For 2Kish alt sites in total, this explains the almost
> exact same increase in text size:
> 
>    text    data     bss     dec     hex filename
> 12290539        1595264 1085440 14971243         e4716b vmlinux
> 
> 338ea55579d1... x86/lib/copy_user_64.S: Remove FIX_ALIGNMENT define
>    text    data     bss     dec     hex filename
> 12290539        1595264 1085440 14971243         e4716b vmlinux
> 
> db477a3386de... x86/alternatives: Cleanup DPRINTK macro
>    text    data     bss     dec     hex filename
> 12290539        1595264 1085440 14971243         e4716b vmlinux
> 
> 4332195c5615... x86/alternatives: Add instruction padding
>    text    data     bss     dec     hex filename
> 12293030        1595264 1085440 14973734         e47b26 vmlinux
> ^^^^^^^

So you could have a look at the detailed section dump itself via:

   objdump -h vmlinux

there .text will be the raw text and .alt* will be listed separately. 
The 'size' tool will add up executable sections IIRC, mixing these 
sections.

.alt* is freed after init, so it's not really a kernel image size 
increase, right?

Thanks,

	Ingo