From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753595AbbCDX5N (ORCPT ); Wed, 4 Mar 2015 18:57:13 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34106 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753565AbbCDX5K (ORCPT ); Wed, 4 Mar 2015 18:57:10 -0500 Date: Wed, 4 Mar 2015 15:57:09 -0800 From: Greg KH To: Charlie Mooney Cc: linux-kernel@vger.kernel.org, dtor@chromium.org, ming.lei@canonical.com Subject: Re: [PATCH] firmware_class: Add firmware filename overrides Message-ID: <20150304235709.GA27233@kroah.com> References: <1425511510-1674-1-git-send-email-charliemooney@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425511510-1674-1-git-send-email-charliemooney@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2015 at 03:25:10PM -0800, Charlie Mooney wrote: > This patch adds an additional feature to the firmware_class.c module. > To allow a unified method of specifying new firmware locations when > drivers request a firmware binary to update their devices with, we > have added the concept of a "fw override" > > A fw override is a rule that matches firmware requests based on the > name of the device requesting the fw and what the filename for the > fw they are requesting is, and overrides their requests with a new > value. > > Overrides are set up by piping a description of the override into > an attribute set up at /sys/class/firmware/fw_override. The string > should be a null-deliminited list of the firmware name you want to > over ride, the new name to replace it with, and the device name that > you want the override to apply to. For example you could set up > an override for a device called "my_device" so that any time it > requests a firmware called "my_fw.bin" it instead gets "new_fw.bin" > with the following command: > > echo -e 'my_fw.bin\0new_fw.bin\0my_device\0' > > /sys/class/firmware/fw_override I hate to ask, but I have to, why do you need this? Also, this needs to be documented somewhere, Documentation/ABI/ please? thanks, greg k-h