From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753370AbbCEAU2 (ORCPT ); Wed, 4 Mar 2015 19:20:28 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:45368 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752161AbbCEAU0 (ORCPT ); Wed, 4 Mar 2015 19:20:26 -0500 Date: Thu, 5 Mar 2015 09:20:16 +0900 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, Sergey Senozhatsky , Jerome Marchand Subject: Re: [PATCH 0/2] make automatic device_id generation possible Message-ID: <20150305001954.GA9563@blaptop> References: <1425478601-19141-1-git-send-email-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425478601-19141-1-git-send-email-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Sergey, On Wed, Mar 04, 2015 at 11:16:39PM +0900, Sergey Senozhatsky wrote: > Hello, > > Make zram-contol/zram_add interface easier to use. Extend it to support > read and write operations. > > Write operation remains the same: > > echo X > /sys/class/zram-control/zram_add > > will add /dev/zramX (or return error). > > > Read operation is treated as 'pick up available device_id, add new > device and return device_id'. > > Example: > cat /sys/class/zram-control/zram_add > 2 > cat /sys/class/zram-control/zram_add > 3 Thanks for handling my concern quickly and sorry for not sending active feedback in realtime. Maybe I should turn on CONFIG_PREEMPT in my brain. I'm not against but I want to know why we should support user-defined device id. What usecase do you have in mind? Could we support automatic id support only at this moment? Then, if some user complains about that in future, we could turn on user-defined device id easily and we could know the usecase. In summary, I want to support only "cat /sys/class/zram-control/zram_add" unless you have feasible usecase. What do you think about it? > > Sergey Senozhatsky (2): > zram: return zram device_id value from zram_add() > zram: introduce automatic device_id generation > > Documentation/ABI/testing/sysfs-class-zram | 7 ++++-- > Documentation/blockdev/zram.txt | 10 ++++++++ > drivers/block/zram/zram_drv.c | 37 ++++++++++++++++++++++++++---- > 3 files changed, 47 insertions(+), 7 deletions(-) > > -- > 2.3.1.167.g7f4ba4b > -- Kind regards, Minchan Kim