From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753615AbbCEAbO (ORCPT ); Wed, 4 Mar 2015 19:31:14 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:35973 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753573AbbCEAbK (ORCPT ); Wed, 4 Mar 2015 19:31:10 -0500 Date: Thu, 5 Mar 2015 09:30:52 +0900 From: Minchan Kim To: Sergey Senozhatsky Cc: ddstreet@ieee.org, gunho.lee@lge.com, iamjoonsoo.kim@lge.com, jmarchan@redhat.com, juno.choi@lge.com, mel@csn.ul.ie, ngupta@vflare.org, semenzato@google.com, sergey.senozhatsky@gmail.com, sjennings@variantweb.net, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: + zram-support-compaction.patch added to -mm tree Message-ID: <20150305003052.GA2592@blaptop> References: <54f780fc.3sOWZKr7rufmI85r%akpm@linux-foundation.org> <20150305001845.GB14927@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150305001845.GB14927@swordfish> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Sergey, On Thu, Mar 05, 2015 at 09:18:45AM +0900, Sergey Senozhatsky wrote: > Hello, > > On (03/04/15 14:02), akpm@linux-foundation.org wrote: > [..] > > +++ a/drivers/block/zram/zram_drv.c > > @@ -70,6 +70,27 @@ static inline struct zram *dev_to_zram(s > > return (struct zram *)dev_to_disk(dev)->private_data; > > } > > > > +static ssize_t compact_store(struct device *dev, > > + struct device_attribute *attr, const char *buf, size_t len) > > +{ > > + unsigned long nr_migrated; > > + struct zram *zram = dev_to_zram(dev); > > + struct zram_meta *meta; > > + > > + down_read(&zram->init_lock); > > + if (!init_done(zram)) { > > + up_read(&zram->init_lock); > > + return -EINVAL; > > + } > > + > > + meta = zram->meta; > > + nr_migrated = zs_compact(meta->mem_pool); > > + atomic64_add(nr_migrated, &zram->stats.num_migrated); > > + up_read(&zram->init_lock); > > + > > + return len; > > +} > > + > > /* flag operations require table entry bit_spin_lock() being held */ > > static int zram_test_flag(struct zram_meta *meta, u32 index, > > enum zram_pageflags flag) > > > let's stick to "helpers, attrs show/store, mm (meta, page), IO, zram control" > function layout. > > so can we please put compact_store() after, say, > 354 static ssize_t comp_algorithm_store(...) > > function? I will clean it up after Andrew releases new mmotm. :) Thanks for the review! -- Kind regards, Minchan Kim