From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754032AbbCEB4b (ORCPT ); Wed, 4 Mar 2015 20:56:31 -0500 Received: from mga03.intel.com ([134.134.136.65]:8346 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753147AbbCEB4a (ORCPT ); Wed, 4 Mar 2015 20:56:30 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,344,1422950400"; d="scan'208";a="462692942" Date: Thu, 5 Mar 2015 09:38:12 +0800 From: Wanpeng Li To: Ingo Molnar , Peter Zijlstra Cc: Juri Lelli , linux-kernel@vger.kernel.org, Wanpeng Li Subject: Re: [PATCH] sched/deadline: don't need to check throttled status when switched to dl Message-ID: <20150305013812.GA2966@kernel> Reply-To: Wanpeng Li References: <1424923864-3001-1-git-send-email-wanpeng.li@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424923864-3001-1-git-send-email-wanpeng.li@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping Juri, On Thu, Feb 26, 2015 at 12:11:04PM +0800, Wanpeng Li wrote: >After commit 40767b0dc768 ("sched/deadline: Fix deadline parameter >modification handling"), deadline task throttled status is cleared >each time switch from dl, so throttled status always unset when >switch back, there is no need to check throttled status, this patch >drop the check. > >Signed-off-by: Wanpeng Li >--- > kernel/sched/deadline.c | 8 -------- > 1 file changed, 8 deletions(-) > >diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c >index ca391c0..cfb8fa7 100644 >--- a/kernel/sched/deadline.c >+++ b/kernel/sched/deadline.c >@@ -1697,14 +1697,6 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p) > { > int check_resched = 1; > >- /* >- * If p is throttled, don't consider the possibility >- * of preempting rq->curr, the check will be done right >- * after its runtime will get replenished. >- */ >- if (unlikely(p->dl.dl_throttled)) >- return; >- > if (task_on_rq_queued(p) && rq->curr != p) { > #ifdef CONFIG_SMP > if (p->nr_cpus_allowed > 1 && rq->dl.overloaded && >-- >1.9.1