From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754563AbbCEHx0 (ORCPT ); Thu, 5 Mar 2015 02:53:26 -0500 Received: from mail-wg0-f47.google.com ([74.125.82.47]:35612 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754412AbbCEHxY (ORCPT ); Thu, 5 Mar 2015 02:53:24 -0500 Date: Thu, 5 Mar 2015 07:53:19 +0000 From: Lee Jones To: Axel Lin Cc: Kishon Vijay Abraham I , Gabriel FERNANDEZ , Alexandre Torgue , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org, Rob Herring Subject: Re: [PATCH 1/2] phy: miphy365x: Convert to devm_kcalloc and fix wrong sizof Message-ID: <20150305075319.GA29183@x1> References: <1425520379.1637.7.camel@phoenix> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1425520379.1637.7.camel@phoenix> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 05 Mar 2015, Axel Lin wrote: > Prefer devm_kcalloc over devm_kzalloc with multiply. > In additional, use sizeof(phy) is incorrect, fix it. > > Signed-off-by: Axel Lin > --- > drivers/phy/phy-miphy365x.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Acked-by: Lee Jones > diff --git a/drivers/phy/phy-miphy365x.c b/drivers/phy/phy-miphy365x.c > index 61177a6..51b459d 100644 > --- a/drivers/phy/phy-miphy365x.c > +++ b/drivers/phy/phy-miphy365x.c > @@ -549,9 +549,8 @@ static int miphy365x_probe(struct platform_device *pdev) > return -ENOMEM; > > miphy_dev->nphys = of_get_child_count(np); > - miphy_dev->phys = devm_kzalloc(&pdev->dev, > - sizeof(phy) * miphy_dev->nphys, > - GFP_KERNEL); > + miphy_dev->phys = devm_kcalloc(&pdev->dev, miphy_dev->nphys, > + sizeof(*miphy_dev->phys), GFP_KERNEL); > if (!miphy_dev->phys) > return -ENOMEM; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog