From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932118AbbCEIt4 (ORCPT ); Thu, 5 Mar 2015 03:49:56 -0500 Received: from mail.skyhub.de ([78.46.96.112]:58735 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbbCEItz (ORCPT ); Thu, 5 Mar 2015 03:49:55 -0500 Date: Thu, 5 Mar 2015 09:48:41 +0100 From: Borislav Petkov To: "Luck, Tony" Cc: Naoya Horiguchi , Prarit Bhargava , Vivek Goyal , "linux-kernel@vger.kernel.org" , Junichi Nomura , Kiyoshi Ueda Subject: Re: [PATCH v4] x86: mce: kexec: switch MCE handler for kexec/kdump Message-ID: <20150305084841.GD3915@pd.tnic> References: <1425373306-26187-1-git-send-email-n-horiguchi@ah.jp.nec.com> <3908561D78D1C84285E8C5FCA982C28F329F5837@ORSMSX114.amr.corp.intel.com> <20150304074117.GA30501@hori1.linux.bs1.fc.nec.co.jp> <3908561D78D1C84285E8C5FCA982C28F329F835A@ORSMSX114.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F329F835A@ORSMSX114.amr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2015 at 11:12:33PM +0000, Luck, Tony wrote: > > - fixed AR and UC order in enum severity_level because UC is severer than AR > > by definition. Current code is not affected by this wrong order by chance. > > AR and AO are both UC errors - that happen also to be recoverable. Are you really sure > about this re-order not affecting existing code? You might well be right, but as every one > else has pointed out mce_severity() is full of odd subtleties that catch people out. Hallelujah! :-) -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --