From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Matteo Semenzato <mattew8898@gmail.com>
Cc: gregkh@linuxfoundation.org, mahati.chamarthy@gmail.com,
jjin082693@gmail.com, peter.senna@gmail.com, quozl@laptop.org,
standby24x7@gmail.com, emilgoode@gmail.com, mdcasey@chabloom.com,
rickard_strandqvist@spectrumdigital.se,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8192e: remove assignment of function parameter
Date: Thu, 5 Mar 2015 15:30:49 +0530 [thread overview]
Message-ID: <20150305100049.GA6292@sudip-PC> (raw)
In-Reply-To: <1425495190-10756-1-git-send-email-mattew8898@gmail.com>
On Wed, Mar 04, 2015 at 07:53:10PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@gmail.com>
>
> This patch removes the assignment of a function parameter that has no
> effect.
then by the same logic you can also remove another rxb = NULL in rtllib_rx_InfraAdhoc() function..
regards
sudip
>
> Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib_rx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index 1664040..c35a5da 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -1226,7 +1226,6 @@ static void rtllib_rx_indicate_pkt_legacy(struct rtllib_device *ieee,
> }
> }
> kfree(rxb);
> - rxb = NULL;
> }
>
> static int rtllib_rx_InfraAdhoc(struct rtllib_device *ieee, struct sk_buff *skb,
> --
> 2.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2015-03-05 10:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 18:53 [PATCH] Staging: rtl8192e: remove assignment of function parameter Matteo Semenzato
2015-03-05 10:00 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305100049.GA6292@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=emilgoode@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jjin082693@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahati.chamarthy@gmail.com \
--cc=mattew8898@gmail.com \
--cc=mdcasey@chabloom.com \
--cc=peter.senna@gmail.com \
--cc=quozl@laptop.org \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox