From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754899AbbCEKcV (ORCPT ); Thu, 5 Mar 2015 05:32:21 -0500 Received: from mail-wi0-f170.google.com ([209.85.212.170]:47019 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872AbbCEKcS (ORCPT ); Thu, 5 Mar 2015 05:32:18 -0500 Date: Thu, 5 Mar 2015 11:32:13 +0100 From: Ingo Molnar To: Arnaldo Carvalho de Melo Cc: Borislav Petkov , Jiri Olsa , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: [PATCH] perf/tui: Change default selection background color to yellow Message-ID: <20150305103213.GA23046@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Boris reported that 'perf top' is unusable on his default 'black on white' terminal, which uses (eye friendly) light-grey as a background color. The reason is that the TUI cursor for the current selection line uses HE_COLORSET_SELECTED, and that has a default background color of 'lightgrey' - which is a common terminal background choice and thus the colors conflict. Use yellow as the background color instead: that should be an uncommon terminal background, yet it's still ergonomic on both black and white/grey terminals. [ It would be a better solution to straight out detect color collisions and resolve them reasonably by converting them to RGB and calculating color space distances, but I was unable to find proper documentation for SLtt_get_color_object() to recover the current color scheme so I gave up ... Yellow works well enough. ] Reported-by: Borislav Petkov Cc: Arnaldo Carvalho de Melo Cc: David Binderman Cc: Jiri Olsa Signed-off-by: Ingo Molnar --- tools/perf/ui/browser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c index 6680fa5cb9dd..688acb94c01f 100644 --- a/tools/perf/ui/browser.c +++ b/tools/perf/ui/browser.c @@ -499,7 +499,7 @@ static struct ui_browser_colorset { .colorset = HE_COLORSET_SELECTED, .name = "selected", .fg = "black", - .bg = "lightgray", + .bg = "yellow", }, { .colorset = HE_COLORSET_CODE,