From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755367AbbCELEm (ORCPT ); Thu, 5 Mar 2015 06:04:42 -0500 Received: from foss.arm.com ([217.140.101.70]:56646 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755213AbbCELEk (ORCPT ); Thu, 5 Mar 2015 06:04:40 -0500 Date: Thu, 5 Mar 2015 11:04:11 +0000 From: Mark Rutland To: Alexandre Belloni , "Rafael J. Wysocki" Cc: Boris Brezillon , Peter Zijlstra , Thomas Gleixner , Jason Cooper , "linux-kernel@vger.kernel.org" , Nicolas Ferre , Jean-Christophe Plagniol-Villard , "linux-arm-kernel@lists.infradead.org" , Linux PM list Subject: Re: [PATCH] genirq: describe IRQF_COND_SUSPEND Message-ID: <20150305110411.GC13617@leverpostej> References: <1424771762-16343-1-git-send-email-boris.brezillon@free-electrons.com> <8151717.nkhnGBri9h@vostro.rjw.lan> <20150226191724.0ae4ca4e@bbrezillon> <6864616.1aRDSmSsvx@vostro.rjw.lan> <20150304194246.GF22156@leverpostej> <20150304200040.GA12126@leverpostej> <20150304221729.GI3989@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150304221729.GI3989@piout.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2015 at 10:17:29PM +0000, Alexandre Belloni wrote: > tiny tiny nitpick: > > On 04/03/2015 at 20:00:40 +0000, Mark Rutland wrote : > > With certain restrictions it is possible for a wakeup device to share > > and IRQ with an IRQF_NO_SUSPEND user, and the warnings introduced by > ^ an Whoops. Rafael, are you happy to fix that up, or would you like me to resend? > > +In rare cases an IRQ can be shared between a wakeup device driver and an > > +IRQF_NO_SUSPEND user. In order for this to be safe, the wakeup device driver > > +must be able to discern spurious IRQs from genuine wakeup events (signalling > > And genuine question, should we use British English or American English > or we don't care ? Have I written something that isn't valid American English there? I read over this a few times and failed to spot anything obvious. I'm happy to change for consistency, I generally assume that's the most important thing. Mark.