From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755668AbbCEMZe (ORCPT ); Thu, 5 Mar 2015 07:25:34 -0500 Received: from foss.arm.com ([217.140.101.70]:56984 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752186AbbCEMZa (ORCPT ); Thu, 5 Mar 2015 07:25:30 -0500 Date: Thu, 5 Mar 2015 12:24:59 +0000 From: Mark Rutland To: Chanwoo Choi Cc: "kgene@kernel.org" , Marc Zyngier , "arnd@arndb.de" , "olof@lixom.net" , Catalin Marinas , Will Deacon , "inki.dae@samsung.com" , "chanho61.park@samsung.com" , "sw0312.kim@samsung.com" , "jh80.chung@samsung.com" , "ideal.song@samsung.com" , "a.kesavan@samsung.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v5 1/9] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC Message-ID: <20150305122459.GC14093@leverpostej> References: <1425533911-14800-1-git-send-email-cw00.choi@samsung.com> <1425533911-14800-2-git-send-email-cw00.choi@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425533911-14800-2-git-send-email-cw00.choi@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 05, 2015 at 05:38:23AM +0000, Chanwoo Choi wrote: > This patch adds new Exynos5433 dtsi to support 64-bit Exynos5433 SoC based on > Octal core CPUs (quad Cortex-A57 and quad Cortex-A53). And Exynos5433 supports > PSCI (Power State Coordination Interface) v0.1. > > This patch includes following dt node to support Exynos5433 SoC: > 1. Octa core for big.LITTLE architecture > - Cortex-A53 LITTLE Quad-core > - Cortex-A57 big Quad-core > - Support PSCI v0.1 [...] > + psci { > + compatible = "arm,psci"; > + method = "smc"; > + cpu_off = <0x84000002>; > + cpu_on = <0xC4000003>; > + }; Back at v2 you mentioned that CPU_OFF wasn't working [1]. Do both CPU_ON and CPU_OFF work for all CPUs, including the boot CPU? I take it CPUs boot at EL2? [...] > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = <1 13 0xff04>, > + <1 14 0xff04>, > + <1 11 0xff04>, > + <1 10 0xff04>; > + }; The timer node should be moved under the root node. It doesn't live on the bus; it's a component of the CPU. Thanks, Mark. [1] https://lkml.org/lkml/2014/12/2/413