From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755609AbbCEMaw (ORCPT ); Thu, 5 Mar 2015 07:30:52 -0500 Received: from mail-we0-f178.google.com ([74.125.82.178]:44640 "EHLO mail-we0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755183AbbCEMav (ORCPT ); Thu, 5 Mar 2015 07:30:51 -0500 Date: Thu, 5 Mar 2015 12:30:45 +0000 From: Lee Jones To: Artem Savkov Cc: beomho.seo@samsung.com, sameo@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: rt5033: MFD_RT5033 needs to select REGMAP_IRQ Message-ID: <20150305123045.GC31098@x1> References: <1425555747-26835-1-git-send-email-asavkov@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1425555747-26835-1-git-send-email-asavkov@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 05 Mar 2015, Artem Savkov wrote: > Since commit 0b2712585(linux-next.git) this driver uses regmap_irq and so needs > to select REGMAP_IRQ. > > This fixes the following compilation errors: > ERROR: "regmap_irq_get_domain" [drivers/mfd/rt5033.ko] undefined! > ERROR: "regmap_add_irq_chip" [drivers/mfd/rt5033.ko] undefined! > > Signed-off-by: Artem Savkov > --- > drivers/mfd/Kconfig | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index f8ef77d9a..f49f404 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -680,6 +680,7 @@ config MFD_RT5033 > depends on I2C=y > select MFD_CORE > select REGMAP_I2C > + select REGMAP_IRQ > help > This driver provides for the Richtek RT5033 Power Management IC, > which includes the I2C driver and the Core APIs. This driver provides -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog