From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754968AbbCENGL (ORCPT ); Thu, 5 Mar 2015 08:06:11 -0500 Received: from mail-qc0-f170.google.com ([209.85.216.170]:43995 "EHLO mail-qc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516AbbCENGJ (ORCPT ); Thu, 5 Mar 2015 08:06:09 -0500 Date: Thu, 5 Mar 2015 08:06:03 -0500 From: Tejun Heo To: Zefan Li Cc: LKML , Cgroups , Ming Lei , Vladimir Davydov Subject: Re: [PATCH -next] cpuset: initialize cpuset a bit early Message-ID: <20150305130603.GD23912@htj.duckdns.org> References: <54F6CBCD.50009@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54F6CBCD.50009@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2015 at 05:09:33PM +0800, Zefan Li wrote: > Now we call ss->bind() in cgroup_init(), so cgroup_init() will > call cpuset_bind() and then the latter will access top_cpuset's > cpumask, which is NULL, because cpuset_init() is called after > cgroup_init() > > The simplest fix is to swap cgroup_init() and cpuset_init(). > > Cc: Vladimir Davydov > Fixes: 295458e67284 ("cgroup: call cgroup_subsys->bind on cgroup subsys initialization") > Reported by: Ming Lei > Signed-off-by: Zefan Li Applied to cgroup/for-4.1. Thanks. -- tejun