From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754678AbbCEMu3 (ORCPT ); Thu, 5 Mar 2015 07:50:29 -0500 Received: from down.free-electrons.com ([37.187.137.238]:57565 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754403AbbCEMu1 (ORCPT ); Thu, 5 Mar 2015 07:50:27 -0500 Date: Thu, 5 Mar 2015 13:50:23 +0100 From: Thomas Petazzoni To: Antoine Tenart Cc: sebastian.hesselbarth@gmail.com, ezequiel.garcia@free-electrons.com, dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, zmxu@marvell.com, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/9] mtd: pxa3xx_nand: rework timings setup Message-ID: <20150305135023.45727776@free-electrons.com> In-Reply-To: <1425555085-29531-5-git-send-email-antoine.tenart@free-electrons.com> References: <1425555085-29531-1-git-send-email-antoine.tenart@free-electrons.com> <1425555085-29531-5-git-send-email-antoine.tenart@free-electrons.com> Organization: Free Electrons X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Antoine Tenart, On Thu, 5 Mar 2015 12:31:20 +0100, Antoine Tenart wrote: > Use the nand framework helpers: onfi_get_async_timing_mode() and > onfi_async_timing_mode_to_sdr_timings() to retrieve the timing > configuration. Then update the pxa3xx timing setup function to use the > timing configuration retrieved. > > Signed-off-by: Antoine Tenart > --- > drivers/mtd/nand/pxa3xx_nand.c | 101 ++++++++++++++++++-------- > include/linux/platform_data/mtd-nand-pxa3xx.h | 2 - > 2 files changed, 69 insertions(+), 34 deletions(-) After this commit, the pxa3xx_nand_timing structure type is no longer used as far as I understand. So maybe it can be removed from include/linux/platform_data/mtd-nand-pxa3xx.h ? Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com