From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756637AbbCEPRX (ORCPT ); Thu, 5 Mar 2015 10:17:23 -0500 Received: from arcturus.aphlor.org ([188.246.204.175]:51468 "EHLO arcturus.aphlor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756284AbbCEPRW (ORCPT ); Thu, 5 Mar 2015 10:17:22 -0500 Date: Thu, 5 Mar 2015 10:17:04 -0500 From: Dave Jones To: Shuah Khan Cc: Michael Ellerman , Namhyung Kim , Steven Rostedt , Linux Kernel Subject: Re: [PATCH] Remove redhat'ism from ftrace selftests. Message-ID: <20150305151704.GA24554@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Shuah Khan , Michael Ellerman , Namhyung Kim , Steven Rostedt , Linux Kernel References: <20150224161927.GA4998@codemonkey.org.uk> <20150224131810.38d73389@gandalf.local.home> <54ECC182.5080109@osg.samsung.com> <20150224182459.GA9018@codemonkey.org.uk> <20150228031602.GD15964@danjae> <54F64C32.1030906@osg.samsung.com> <1425466067.32154.9.camel@ellerman.id.au> <20150304124457.GK27046@danjae> <1425518337.32154.17.camel@ellerman.id.au> <54F872E2.9000708@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54F872E2.9000708@osg.samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Report: Spam report generated by SpamAssassin on "arcturus.aphlor.org" Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Authenticated-User: davej@codemonkey.org.uk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 05, 2015 at 08:14:42AM -0700, Shuah Khan wrote: > On 03/04/2015 06:18 PM, Michael Ellerman wrote: > > On Wed, 2015-03-04 at 21:44 +0900, Namhyung Kim wrote: > >> > >> I think that there's no need to even call true or echo.. > >> > >> From 0549544e8e982df6478f11e2b4fe419f94c22434 Mon Sep 17 00:00:00 2001 > >> From: Namhyung Kim > >> Date: Wed, 4 Mar 2015 21:26:38 +0900 > >> Subject: [PATCH] ftracetest: Do not use usleep > >> > >> The usleep is only provided on distros from Redhat so running ftracetest > >> on other distro resulted in failures due to the missing usleep. > >> > >> The reason of using [u]sleep in the test was to generate (scheduler) > >> events. But as we use 'cat trace | grep | wc -l' to read the events, > >> the command themselves already generate some events before reading the > >> trace file so no need to call [u]sleep explicitly. > >> > >> Reported-by: Michael Ellerman > >> Reported-by: Dave Jones > >> Signed-off-by: Namhyung Kim > > > > Thanks, this is working for me. > > > > Tested-by: Michael Ellerman > > > > Steve, > > Do you want to make a call on which one you want me to take it > through between these two patches - one from Dave and the other > from Namhyung Kim. > > Please send me the patch I have to pull in. Namhyung Kim's patch > isn't in the format I can apply and I don't have Dave's patch in > my inbox. Removing it entirely sounds like a much better choice, so I'd wait for Namhyung to resend. Dave