From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965055AbbCEPye (ORCPT ); Thu, 5 Mar 2015 10:54:34 -0500 Received: from down.free-electrons.com ([37.187.137.238]:59133 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752743AbbCEPyd (ORCPT ); Thu, 5 Mar 2015 10:54:33 -0500 Date: Thu, 5 Mar 2015 16:52:34 +0100 From: Alexandre Belloni To: Alexander Stein Cc: Nicolas Ferre , Jean-Christophe Plagniol-Villard , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Boris Brezillon Subject: Re: [PATCH v2 5/9] ARM: at91: add soc detection infrastructure Message-ID: <20150305155234.GU3989@piout.net> References: <1425557486-3534-1-git-send-email-alexandre.belloni@free-electrons.com> <1425557486-3534-6-git-send-email-alexandre.belloni@free-electrons.com> <1425580851.g2DuYFu1co@ws-stein> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425580851.g2DuYFu1co@ws-stein> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/03/2015 at 16:29:26 +0100, Alexander Stein wrote : > > + if (!regs) { > > + pr_warn("Could not map DBGU iomem range"); > > + iounmap(regs); > > I guess if regs == NULL there is no need to iounmap them, no? > Indeed :) -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com