From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757849AbbCEQSq (ORCPT ); Thu, 5 Mar 2015 11:18:46 -0500 Received: from mga09.intel.com ([134.134.136.24]:42419 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756905AbbCEQSo (ORCPT ); Thu, 5 Mar 2015 11:18:44 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,347,1422950400"; d="scan'208";a="462979665" Date: Thu, 5 Mar 2015 21:45:27 +0530 From: Vinod Koul To: Stanimir Varbanov Cc: Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2] dmaengine: bam-dma: fix a warning about missing capabilities Message-ID: <20150305161527.GH2613@intel.com> References: <1425560584-3721-1-git-send-email-stanimir.varbanov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425560584-3721-1-git-send-email-stanimir.varbanov@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 05, 2015 at 03:03:04PM +0200, Stanimir Varbanov wrote: > Avoid the warning below triggered during dmaengine async device > registration. > > WARNING: CPU: 1 PID: 1 at linux/drivers/dma/dmaengine.c:863 > dma_async_device_register+0x2a8/0x4b8() > this driver doesn't support generic slave capabilities reporting > > To do that fill mandatory .directions bit mask, > .src/dst_addr_widths and .residue_granularity dma_device fields > with appropriate values. > Applied, thanks -- ~Vinod > Signed-off-by: Stanimir Varbanov > --- > > v1 -> v2 > > - the patch subject has been changed > - now fill also .residue_granularity and src/dts_addr_widths > - added the warning in patch description > > v1 can be found at https://lkml.org/lkml/2015/3/4/896 > > drivers/dma/qcom_bam_dma.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/dma/qcom_bam_dma.c b/drivers/dma/qcom_bam_dma.c > index c3113e3..9c914d6 100644 > --- a/drivers/dma/qcom_bam_dma.c > +++ b/drivers/dma/qcom_bam_dma.c > @@ -1143,6 +1143,10 @@ static int bam_dma_probe(struct platform_device *pdev) > dma_cap_set(DMA_SLAVE, bdev->common.cap_mask); > > /* initialize dmaengine apis */ > + bdev->common.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV); > + bdev->common.residue_granularity = DMA_RESIDUE_GRANULARITY_SEGMENT; > + bdev->common.src_addr_widths = DMA_SLAVE_BUSWIDTH_4_BYTES; > + bdev->common.dst_addr_widths = DMA_SLAVE_BUSWIDTH_4_BYTES; > bdev->common.device_alloc_chan_resources = bam_alloc_chan; > bdev->common.device_free_chan_resources = bam_free_chan; > bdev->common.device_prep_slave_sg = bam_prep_slave_sg; > -- > 1.7.0.4 > --