public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers: dma: Remove extra check
@ 2015-02-20 12:28 Tapasweni Pathak
  2015-03-05 16:39 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Tapasweni Pathak @ 2015-02-20 12:28 UTC (permalink / raw)
  To: dan.j.williams, vinod.koul, dmaengine, linux-kernel
  Cc: julia.lawall, tapaswenipathak

Remove double check on chan->desc.

Found by Coccinelle.

Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
 drivers/dma/dma-jz4740.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/dma-jz4740.c b/drivers/dma/dma-jz4740.c
index 4527a3e..f6a4c42 100644
--- a/drivers/dma/dma-jz4740.c
+++ b/drivers/dma/dma-jz4740.c
@@ -343,7 +343,7 @@ static void jz4740_dma_chan_irq(struct jz4740_dmaengine_chan *chan)
 {
 	spin_lock(&chan->vchan.lock);
 	if (chan->desc) {
-		if (chan->desc && chan->desc->cyclic) {
+		if (chan->desc->cyclic) {
 			vchan_cyclic_callback(&chan->desc->vdesc);
 		} else {
 			if (chan->next_sg == chan->desc->num_sgs) {
--
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers: dma: Remove extra check
  2015-02-20 12:28 [PATCH] drivers: dma: Remove extra check Tapasweni Pathak
@ 2015-03-05 16:39 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2015-03-05 16:39 UTC (permalink / raw)
  To: Tapasweni Pathak; +Cc: dan.j.williams, dmaengine, linux-kernel, julia.lawall

On Fri, Feb 20, 2015 at 05:58:44PM +0530, Tapasweni Pathak wrote:
> Remove double check on chan->desc.
> 
> Found by Coccinelle.
> 
Please use the right substem name in patches. Hint git log is your friend

Applied, now

-- 
~Vinod


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-05 16:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-20 12:28 [PATCH] drivers: dma: Remove extra check Tapasweni Pathak
2015-03-05 16:39 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox