public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dma: mmp_pdma: fix warning about slave caps
@ 2015-02-15 18:49 Robert Jarzmik
  2015-03-05 16:46 ` Vinod Koul
  0 siblings, 1 reply; 3+ messages in thread
From: Robert Jarzmik @ 2015-02-15 18:49 UTC (permalink / raw)
  To: Vinod Koul; +Cc: dmaengine, linux-kernel, Daniel Mack, Robert Jarzmik

Fix the dmaengine complaint about missing slave caps :
 - declare the available bus widths
 - declare the available transfer types
 - declare the residue calculation type

Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
 drivers/dma/mmp_pdma.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c
index 1b82bd6..cadd9e5 100644
--- a/drivers/dma/mmp_pdma.c
+++ b/drivers/dma/mmp_pdma.c
@@ -1018,6 +1018,9 @@ static int mmp_pdma_probe(struct platform_device *op)
 	struct resource *iores;
 	int i, ret, irq = 0;
 	int dma_channels = 0, irq_num = 0;
+	const enum dma_slave_buswidth widths =
+		DMA_SLAVE_BUSWIDTH_1_BYTE   | DMA_SLAVE_BUSWIDTH_2_BYTES |
+		DMA_SLAVE_BUSWIDTH_4_BYTES;
 
 	pdev = devm_kzalloc(&op->dev, sizeof(*pdev), GFP_KERNEL);
 	if (!pdev)
@@ -1085,6 +1088,10 @@ static int mmp_pdma_probe(struct platform_device *op)
 	pdev->device.device_config = mmp_pdma_config;
 	pdev->device.device_terminate_all = mmp_pdma_terminate_all;
 	pdev->device.copy_align = PDMA_ALIGNMENT;
+	pdev->device.src_addr_widths = widths;
+	pdev->device.dst_addr_widths = widths;
+	pdev->device.directions = BIT(DMA_MEM_TO_DEV) | BIT(DMA_DEV_TO_MEM);
+	pdev->device.residue_granularity = DMA_RESIDUE_GRANULARITY_DESCRIPTOR;
 
 	if (pdev->dev->coherent_dma_mask)
 		dma_set_mask(pdev->dev, pdev->dev->coherent_dma_mask);
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dma: mmp_pdma: fix warning about slave caps
  2015-02-15 18:49 [PATCH] dma: mmp_pdma: fix warning about slave caps Robert Jarzmik
@ 2015-03-05 16:46 ` Vinod Koul
  2015-03-05 16:59   ` Robert Jarzmik
  0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2015-03-05 16:46 UTC (permalink / raw)
  To: Robert Jarzmik; +Cc: dmaengine, linux-kernel, Daniel Mack

On Sun, Feb 15, 2015 at 07:49:16PM +0100, Robert Jarzmik wrote:
> Fix the dmaengine complaint about missing slave caps :
>  - declare the available bus widths
>  - declare the available transfer types
>  - declare the residue calculation type
> 
Applied, thanks

-- 
~Vinod


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dma: mmp_pdma: fix warning about slave caps
  2015-03-05 16:46 ` Vinod Koul
@ 2015-03-05 16:59   ` Robert Jarzmik
  0 siblings, 0 replies; 3+ messages in thread
From: Robert Jarzmik @ 2015-03-05 16:59 UTC (permalink / raw)
  To: Vinod Koul; +Cc: dmaengine, linux-kernel, Daniel Mack

Vinod Koul <vinod.koul@intel.com> writes:

> On Sun, Feb 15, 2015 at 07:49:16PM +0100, Robert Jarzmik wrote:
>> Fix the dmaengine complaint about missing slave caps :
>>  - declare the available bus widths
>>  - declare the available transfer types
>>  - declare the residue calculation type
>> 
> Applied, thanks
Thanks Vinod.

Cheers.

-- 
Robert

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-05 16:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-15 18:49 [PATCH] dma: mmp_pdma: fix warning about slave caps Robert Jarzmik
2015-03-05 16:46 ` Vinod Koul
2015-03-05 16:59   ` Robert Jarzmik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox