From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755882AbbCFK6Y (ORCPT ); Fri, 6 Mar 2015 05:58:24 -0500 Received: from mail-we0-f181.google.com ([74.125.82.181]:42488 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755853AbbCFK6S (ORCPT ); Fri, 6 Mar 2015 05:58:18 -0500 Date: Fri, 6 Mar 2015 10:58:11 +0000 From: Lee Jones To: Alexandre Belloni Cc: Nicolas Ferre , Daniel Lezcano , Boris Brezillon , Jean-Christophe Plagniol-Villard , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Sebastian Reichel , Dmitry Eremin-Solenikov , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v4 2/9] mfd: syscon: Add atmel system timer registers definition Message-ID: <20150306105811.GC3318@x1> References: <1425570594-13124-1-git-send-email-alexandre.belloni@free-electrons.com> <1425570594-13124-3-git-send-email-alexandre.belloni@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1425570594-13124-3-git-send-email-alexandre.belloni@free-electrons.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 05 Mar 2015, Alexandre Belloni wrote: > AT91RM920 has a memory range reserved for timer and watchdog configuration. > Expose those registers so that drivers can make use of the system timer syscon > declared in at91 DTs. > > Signed-off-by: Alexandre Belloni > --- > include/linux/mfd/syscon/atmel-st.h | 49 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 include/linux/mfd/syscon/atmel-st.h > > diff --git a/include/linux/mfd/syscon/atmel-st.h b/include/linux/mfd/syscon/atmel-st.h > new file mode 100644 > index 000000000000..93c7affc2809 > --- /dev/null > +++ b/include/linux/mfd/syscon/atmel-st.h > @@ -0,0 +1,49 @@ > +/* > + * Copyright (C) 2005 Ivan Kokshaysky > + * Copyright (C) SAN People > + * > + * System Timer (ST) - System peripherals registers. > + * Based on AT91RM9200 datasheet revision E. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + */ > + > +#ifndef _LINUX_MFD_SYSCON_ATMEL_ST_H > +#define _LINUX_MFD_SYSCON_ATMEL_ST_H > + > +#include > + > +#define AT91_ST_CR 0x00 /* Control Register */ > +#define AT91_ST_WDRST BIT(0) /* Watchdog Timer Restart */ Sorry for the incremental reviews, I'm exceptionally busy of late. The next white space character after #define should be a humble space. ... at least for the register defines. The bit assignments can be tabbed out to denote what they are. Once fixed, please resend with my: Acked-by: Lee Jones > +#define AT91_ST_PIMR 0x04 /* Period Interval Mode Register */ > +#define AT91_ST_PIV 0xffff /* Period Interval Value */ > + > +#define AT91_ST_WDMR 0x08 /* Watchdog Mode Register */ > +#define AT91_ST_WDV 0xffff /* Watchdog Counter Value */ > +#define AT91_ST_RSTEN BIT(16) /* Reset Enable */ > +#define AT91_ST_EXTEN BIT(17) /* External Signal Assertion Enable */ > + > +#define AT91_ST_RTMR 0x0c /* Real-time Mode Register */ > +#define AT91_ST_RTPRES 0xffff /* Real-time Prescalar Value */ > + > +#define AT91_ST_SR 0x10 /* Status Register */ > +#define AT91_ST_PITS BIT(0) /* Period Interval Timer Status */ > +#define AT91_ST_WDOVF BIT(1) /* Watchdog Overflow */ > +#define AT91_ST_RTTINC BIT(2) /* Real-time Timer Increment */ > +#define AT91_ST_ALMS BIT(3) /* Alarm Status */ > + > +#define AT91_ST_IER 0x14 /* Interrupt Enable Register */ > +#define AT91_ST_IDR 0x18 /* Interrupt Disable Register */ > +#define AT91_ST_IMR 0x1c /* Interrupt Mask Register */ > + > +#define AT91_ST_RTAR 0x20 /* Real-time Alarm Register */ > +#define AT91_ST_ALMV 0xfffff /* Alarm Value */ > + > +#define AT91_ST_CRTR 0x24 /* Current Real-time Register */ > +#define AT91_ST_CRTV 0xfffff /* Current Real-Time Value */ > + > +#endif /* _LINUX_MFD_SYSCON_ATMEL_ST_H */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog