public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Chris Zhong <zyw@rock-chips.com>
Cc: heiko@sntech.de, dianders@chromium.org, dtor@chromium.org,
	djkurtz@chromium.org, sonnyrao@chromium.org,
	linux-rockchip@lists.infradead.org,
	Samuel Ortiz <sameo@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: rk808: disable the under voltage detect
Date: Fri, 6 Mar 2015 12:03:33 +0000	[thread overview]
Message-ID: <20150306120333.GE3318@x1> (raw)
In-Reply-To: <1425118146-13734-1-git-send-email-zyw@rock-chips.com>

On Sat, 28 Feb 2015, Chris Zhong wrote:

> Rk808 has a under voltage detect function, when the voltage of buck is
> under 85% the target voltage, the buck output will reset. But if the
> power load is too heavy, this function maybe err, when current over
> 4.2A, although the voltage is normal, but RK808 mistakenly think it is
> under 85%, and reset the buck. So let's disable this function.
> 
> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
> 
> ---
> 
>  drivers/mfd/rk808.c       | 1 +
>  include/linux/mfd/rk808.h | 3 +++
>  2 files changed, 4 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
> index bd02150..7cf25c7 100644
> --- a/drivers/mfd/rk808.c
> +++ b/drivers/mfd/rk808.c
> @@ -89,6 +89,7 @@ static const struct rk808_reg_data pre_init_reg[] = {
>  	{ RK808_BOOST_CONFIG_REG, BOOST_ILMIN_MASK, BOOST_ILMIN_100MA },
>  	{ RK808_BUCK1_CONFIG_REG, BUCK1_RATE_MASK,  BUCK_ILMIN_200MA },
>  	{ RK808_BUCK2_CONFIG_REG, BUCK2_RATE_MASK,  BUCK_ILMIN_200MA },
> +	{ RK808_DCDC_UV_ACT_REG,  BUCK_UV_ACT_MASK, BUCK_UV_ACT_DISABLE},
>  	{ RK808_VB_MON_REG,       MASK_ALL,         VB_LO_ACT |
>  						    VB_LO_SEL_3500MV },
>  };
> diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h
> index fb09312..441b6ee 100644
> --- a/include/linux/mfd/rk808.h
> +++ b/include/linux/mfd/rk808.h
> @@ -156,6 +156,9 @@ enum rk808_reg {
>  #define BUCK2_RATE_MASK		(3 << 3)
>  #define MASK_ALL	0xff
>  
> +#define BUCK_UV_ACT_MASK	0x0f
> +#define BUCK_UV_ACT_DISABLE	0
> +
>  #define SWITCH2_EN	BIT(6)
>  #define SWITCH1_EN	BIT(5)
>  #define DEV_OFF_RST	BIT(3)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

      reply	other threads:[~2015-03-06 12:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-28 10:09 [PATCH] mfd: rk808: disable the under voltage detect Chris Zhong
2015-03-06 12:03 ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150306120333.GE3318@x1 \
    --to=lee.jones@linaro.org \
    --cc=dianders@chromium.org \
    --cc=djkurtz@chromium.org \
    --cc=dtor@chromium.org \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=sameo@linux.intel.com \
    --cc=sonnyrao@chromium.org \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox