public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mfd: rk808: disable the under voltage detect
@ 2015-02-28 10:09 Chris Zhong
  2015-03-06 12:03 ` Lee Jones
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Zhong @ 2015-02-28 10:09 UTC (permalink / raw)
  To: heiko, dianders, dtor, djkurtz, sonnyrao
  Cc: linux-rockchip, Chris Zhong, Samuel Ortiz, Lee Jones,
	linux-kernel

Rk808 has a under voltage detect function, when the voltage of buck is
under 85% the target voltage, the buck output will reset. But if the
power load is too heavy, this function maybe err, when current over
4.2A, although the voltage is normal, but RK808 mistakenly think it is
under 85%, and reset the buck. So let's disable this function.

Signed-off-by: Chris Zhong <zyw@rock-chips.com>

---

 drivers/mfd/rk808.c       | 1 +
 include/linux/mfd/rk808.h | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
index bd02150..7cf25c7 100644
--- a/drivers/mfd/rk808.c
+++ b/drivers/mfd/rk808.c
@@ -89,6 +89,7 @@ static const struct rk808_reg_data pre_init_reg[] = {
 	{ RK808_BOOST_CONFIG_REG, BOOST_ILMIN_MASK, BOOST_ILMIN_100MA },
 	{ RK808_BUCK1_CONFIG_REG, BUCK1_RATE_MASK,  BUCK_ILMIN_200MA },
 	{ RK808_BUCK2_CONFIG_REG, BUCK2_RATE_MASK,  BUCK_ILMIN_200MA },
+	{ RK808_DCDC_UV_ACT_REG,  BUCK_UV_ACT_MASK, BUCK_UV_ACT_DISABLE},
 	{ RK808_VB_MON_REG,       MASK_ALL,         VB_LO_ACT |
 						    VB_LO_SEL_3500MV },
 };
diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h
index fb09312..441b6ee 100644
--- a/include/linux/mfd/rk808.h
+++ b/include/linux/mfd/rk808.h
@@ -156,6 +156,9 @@ enum rk808_reg {
 #define BUCK2_RATE_MASK		(3 << 3)
 #define MASK_ALL	0xff
 
+#define BUCK_UV_ACT_MASK	0x0f
+#define BUCK_UV_ACT_DISABLE	0
+
 #define SWITCH2_EN	BIT(6)
 #define SWITCH1_EN	BIT(5)
 #define DEV_OFF_RST	BIT(3)
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mfd: rk808: disable the under voltage detect
  2015-02-28 10:09 [PATCH] mfd: rk808: disable the under voltage detect Chris Zhong
@ 2015-03-06 12:03 ` Lee Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2015-03-06 12:03 UTC (permalink / raw)
  To: Chris Zhong
  Cc: heiko, dianders, dtor, djkurtz, sonnyrao, linux-rockchip,
	Samuel Ortiz, linux-kernel

On Sat, 28 Feb 2015, Chris Zhong wrote:

> Rk808 has a under voltage detect function, when the voltage of buck is
> under 85% the target voltage, the buck output will reset. But if the
> power load is too heavy, this function maybe err, when current over
> 4.2A, although the voltage is normal, but RK808 mistakenly think it is
> under 85%, and reset the buck. So let's disable this function.
> 
> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
> 
> ---
> 
>  drivers/mfd/rk808.c       | 1 +
>  include/linux/mfd/rk808.h | 3 +++
>  2 files changed, 4 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
> index bd02150..7cf25c7 100644
> --- a/drivers/mfd/rk808.c
> +++ b/drivers/mfd/rk808.c
> @@ -89,6 +89,7 @@ static const struct rk808_reg_data pre_init_reg[] = {
>  	{ RK808_BOOST_CONFIG_REG, BOOST_ILMIN_MASK, BOOST_ILMIN_100MA },
>  	{ RK808_BUCK1_CONFIG_REG, BUCK1_RATE_MASK,  BUCK_ILMIN_200MA },
>  	{ RK808_BUCK2_CONFIG_REG, BUCK2_RATE_MASK,  BUCK_ILMIN_200MA },
> +	{ RK808_DCDC_UV_ACT_REG,  BUCK_UV_ACT_MASK, BUCK_UV_ACT_DISABLE},
>  	{ RK808_VB_MON_REG,       MASK_ALL,         VB_LO_ACT |
>  						    VB_LO_SEL_3500MV },
>  };
> diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h
> index fb09312..441b6ee 100644
> --- a/include/linux/mfd/rk808.h
> +++ b/include/linux/mfd/rk808.h
> @@ -156,6 +156,9 @@ enum rk808_reg {
>  #define BUCK2_RATE_MASK		(3 << 3)
>  #define MASK_ALL	0xff
>  
> +#define BUCK_UV_ACT_MASK	0x0f
> +#define BUCK_UV_ACT_DISABLE	0
> +
>  #define SWITCH2_EN	BIT(6)
>  #define SWITCH1_EN	BIT(5)
>  #define DEV_OFF_RST	BIT(3)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-06 12:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-28 10:09 [PATCH] mfd: rk808: disable the under voltage detect Chris Zhong
2015-03-06 12:03 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox