From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754237AbbCFMDl (ORCPT ); Fri, 6 Mar 2015 07:03:41 -0500 Received: from mail-wi0-f172.google.com ([209.85.212.172]:37336 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752614AbbCFMDj (ORCPT ); Fri, 6 Mar 2015 07:03:39 -0500 Date: Fri, 6 Mar 2015 12:03:33 +0000 From: Lee Jones To: Chris Zhong Cc: heiko@sntech.de, dianders@chromium.org, dtor@chromium.org, djkurtz@chromium.org, sonnyrao@chromium.org, linux-rockchip@lists.infradead.org, Samuel Ortiz , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: rk808: disable the under voltage detect Message-ID: <20150306120333.GE3318@x1> References: <1425118146-13734-1-git-send-email-zyw@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1425118146-13734-1-git-send-email-zyw@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 28 Feb 2015, Chris Zhong wrote: > Rk808 has a under voltage detect function, when the voltage of buck is > under 85% the target voltage, the buck output will reset. But if the > power load is too heavy, this function maybe err, when current over > 4.2A, although the voltage is normal, but RK808 mistakenly think it is > under 85%, and reset the buck. So let's disable this function. > > Signed-off-by: Chris Zhong > > --- > > drivers/mfd/rk808.c | 1 + > include/linux/mfd/rk808.h | 3 +++ > 2 files changed, 4 insertions(+) Applied, thanks. > diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c > index bd02150..7cf25c7 100644 > --- a/drivers/mfd/rk808.c > +++ b/drivers/mfd/rk808.c > @@ -89,6 +89,7 @@ static const struct rk808_reg_data pre_init_reg[] = { > { RK808_BOOST_CONFIG_REG, BOOST_ILMIN_MASK, BOOST_ILMIN_100MA }, > { RK808_BUCK1_CONFIG_REG, BUCK1_RATE_MASK, BUCK_ILMIN_200MA }, > { RK808_BUCK2_CONFIG_REG, BUCK2_RATE_MASK, BUCK_ILMIN_200MA }, > + { RK808_DCDC_UV_ACT_REG, BUCK_UV_ACT_MASK, BUCK_UV_ACT_DISABLE}, > { RK808_VB_MON_REG, MASK_ALL, VB_LO_ACT | > VB_LO_SEL_3500MV }, > }; > diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h > index fb09312..441b6ee 100644 > --- a/include/linux/mfd/rk808.h > +++ b/include/linux/mfd/rk808.h > @@ -156,6 +156,9 @@ enum rk808_reg { > #define BUCK2_RATE_MASK (3 << 3) > #define MASK_ALL 0xff > > +#define BUCK_UV_ACT_MASK 0x0f > +#define BUCK_UV_ACT_DISABLE 0 > + > #define SWITCH2_EN BIT(6) > #define SWITCH1_EN BIT(5) > #define DEV_OFF_RST BIT(3) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog