From: Lee Jones <lee.jones@linaro.org>
To: Ameya Palande <2ameya@gmail.com>
Cc: linux-kernel@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] mfd: kempld-core: Fix callback return value check
Date: Fri, 6 Mar 2015 12:04:16 +0000 [thread overview]
Message-ID: <20150306120416.GF3318@x1> (raw)
In-Reply-To: <1424981151-1561-1-git-send-email-2ameya@gmail.com>
On Thu, 26 Feb 2015, Ameya Palande wrote:
> On success, callback function returns 0. So invert the if condition
> check so that we can break out of loop.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Ameya Palande <2ameya@gmail.com>
> ---
> drivers/mfd/kempld-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c
> index f38ec42..5615522 100644
> --- a/drivers/mfd/kempld-core.c
> +++ b/drivers/mfd/kempld-core.c
> @@ -739,7 +739,7 @@ static int __init kempld_init(void)
> for (id = kempld_dmi_table;
> id->matches[0].slot != DMI_NONE; id++)
> if (strstr(id->ident, force_device_id))
> - if (id->callback && id->callback(id))
> + if (id->callback && !id->callback(id))
> break;
> if (id->matches[0].slot == DMI_NONE)
> return -ENODEV;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2015-03-06 12:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 20:05 [PATCH] mfd: kempld-core: Fix callback return value check Ameya Palande
2015-03-06 12:04 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306120416.GF3318@x1 \
--to=lee.jones@linaro.org \
--cc=2ameya@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox