From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754345AbbCFMEX (ORCPT ); Fri, 6 Mar 2015 07:04:23 -0500 Received: from mail-we0-f175.google.com ([74.125.82.175]:36367 "EHLO mail-we0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754260AbbCFMEV (ORCPT ); Fri, 6 Mar 2015 07:04:21 -0500 Date: Fri, 6 Mar 2015 12:04:16 +0000 From: Lee Jones To: Ameya Palande <2ameya@gmail.com> Cc: linux-kernel@vger.kernel.org, Samuel Ortiz Subject: Re: [PATCH] mfd: kempld-core: Fix callback return value check Message-ID: <20150306120416.GF3318@x1> References: <1424981151-1561-1-git-send-email-2ameya@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1424981151-1561-1-git-send-email-2ameya@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Feb 2015, Ameya Palande wrote: > On success, callback function returns 0. So invert the if condition > check so that we can break out of loop. > > Cc: stable@vger.kernel.org > Signed-off-by: Ameya Palande <2ameya@gmail.com> > --- > drivers/mfd/kempld-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c > index f38ec42..5615522 100644 > --- a/drivers/mfd/kempld-core.c > +++ b/drivers/mfd/kempld-core.c > @@ -739,7 +739,7 @@ static int __init kempld_init(void) > for (id = kempld_dmi_table; > id->matches[0].slot != DMI_NONE; id++) > if (strstr(id->ident, force_device_id)) > - if (id->callback && id->callback(id)) > + if (id->callback && !id->callback(id)) > break; > if (id->matches[0].slot == DMI_NONE) > return -ENODEV; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog