From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756869AbbCFL0J (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Mar 2015 06:26:09 -0500
Received: from down.free-electrons.com ([37.187.137.238]:36970 "EHLO
	mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1756841AbbCFL0G (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Mar 2015 06:26:06 -0500
Date: Fri, 6 Mar 2015 12:25:49 +0100
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        Nicolas Ferre <nicolas.ferre@atmel.com>,
        Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] net: macb: remove #if defined(CONFIG_ARCH_AT91)
 sections
Message-ID: <20150306122549.314c6439@bbrezillon>
In-Reply-To: <20150305194418.GY3989@piout.net>
References: <1425572842-6084-1-git-send-email-boris.brezillon@free-electrons.com>
	<1425572842-6084-4-git-send-email-boris.brezillon@free-electrons.com>
	<20150305194418.GY3989@piout.net>
X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 5 Mar 2015 20:44:18 +0100
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:

> On 05/03/2015 at 17:27:22 +0100, Boris Brezillon wrote :
> > @@ -2388,21 +2392,20 @@ static int macb_probe(struct platform_device *pdev)
> >  		bp->phy_interface = err;
> >  	}
> >  
> > +	config = 0;
> >  	if (bp->phy_interface == PHY_INTERFACE_MODE_RGMII)
> > -		macb_or_gem_writel(bp, USRIO, GEM_BIT(RGMII));
> > -	else if (bp->phy_interface == PHY_INTERFACE_MODE_RMII)
> > -#if defined(CONFIG_ARCH_AT91)
> > -		macb_or_gem_writel(bp, USRIO, (MACB_BIT(RMII) |
> > -					       MACB_BIT(CLKEN)));
> > -#else
> > -		macb_or_gem_writel(bp, USRIO, 0);
> > -#endif
> > -	else
> > -#if defined(CONFIG_ARCH_AT91)
> > -		macb_or_gem_writel(bp, USRIO, MACB_BIT(CLKEN));
> > -#else
> > -		macb_or_gem_writel(bp, USRIO, MACB_BIT(MII));
> > -#endif
> > +		config = GEM_BIT(RGMII);
> > +	else if (bp->phy_interface == PHY_INTERFACE_MODE_RMII &&
> > +		 (bp->caps & MACB_CAPS_USRIO_DEFAULT_IS_MII))
> > +		config = MACB_BIT(RMII);
> > +	else if (bp->phy_interface == PHY_INTERFACE_MODE_MII &&
> 
> I'm not sure you should check for PHY_INTERFACE_MODE_MII here as this
> may change the previous behaviour.

Absolutely (I fixed it in v2).

Thanks,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com