From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753969AbbCFN44 (ORCPT ); Fri, 6 Mar 2015 08:56:56 -0500 Received: from mail.skyhub.de ([78.46.96.112]:60933 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843AbbCFN4v (ORCPT ); Fri, 6 Mar 2015 08:56:51 -0500 Date: Fri, 6 Mar 2015 14:55:34 +0100 From: Borislav Petkov To: Yinghai Lu Cc: Matt Fleming , "H. Peter Anvin" , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Jiri Kosina , Borislav Petkov , Baoquan He , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-pci@vger.kernel.org, Josh Triplett , Kees Cook , Andrew Morton , Ard Biesheuvel , Junjie Mao Subject: Re: [PATCH v2 01/15] x86, kaslr: Use init_size instead of run_size Message-ID: <20150306135534.GD4259@pd.tnic> References: <1425456048-16236-1-git-send-email-yinghai@kernel.org> <1425456048-16236-2-git-send-email-yinghai@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1425456048-16236-2-git-send-email-yinghai@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2015 at 12:00:34AM -0800, Yinghai Lu wrote: > commit e6023367d779 ("x86, kaslr: Prevent .bss from overlaping initrd") > > introduced one run_size for kaslr. > > We do not need to have home grown run_size. > > We should use real runtime size (include copy/decompress) aka init_size Why? I can see why but you need to explain it here. Also, look at the e6023367d779 commit message. Now this is how you do a commit message! Especially if it is early boot code, you explain stuff. Junjie even went the distance and did a nice graphic. So please redo your commit message. And saying it is trivial and obvious will not get you anywhere, as you've noticed already. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --