* [PATCH] serial:8250:8250_pci: delete unneeded quirk entries
@ 2015-03-06 17:08 Wang YanQing
2015-03-06 21:21 ` Bryan O'Donoghue
0 siblings, 1 reply; 3+ messages in thread
From: Wang YanQing @ 2015-03-06 17:08 UTC (permalink / raw)
To: gregkh; +Cc: linux-serial, linux-kernel, pure.logic
These quirk entries have the same effect as default
quirk entry, so we can just delete them.
Signed-off-by: Wang YanQing <udknight@gmail.com>
---
drivers/tty/serial/8250/8250_pci.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index daf2c82..cf1cab1 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -1989,13 +1989,6 @@ static struct pci_serial_quirk pci_serial_quirks[] __refdata = {
},
{
.vendor = PCI_VENDOR_ID_INTEL,
- .device = PCI_DEVICE_ID_INTEL_QRK_UART,
- .subvendor = PCI_ANY_ID,
- .subdevice = PCI_ANY_ID,
- .setup = pci_default_setup,
- },
- {
- .vendor = PCI_VENDOR_ID_INTEL,
.device = PCI_DEVICE_ID_INTEL_BSW_UART1,
.subvendor = PCI_ANY_ID,
.subdevice = PCI_ANY_ID,
@@ -2201,13 +2194,6 @@ static struct pci_serial_quirk pci_serial_quirks[] __refdata = {
*/
{
.vendor = PCI_VENDOR_ID_PLX,
- .device = PCI_DEVICE_ID_PLX_9030,
- .subvendor = PCI_SUBVENDOR_ID_PERLE,
- .subdevice = PCI_ANY_ID,
- .setup = pci_default_setup,
- },
- {
- .vendor = PCI_VENDOR_ID_PLX,
.device = PCI_DEVICE_ID_PLX_9050,
.subvendor = PCI_SUBVENDOR_ID_EXSYS,
.subdevice = PCI_SUBDEVICE_ID_EXSYS_4055,
--
2.2.2.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] serial:8250:8250_pci: delete unneeded quirk entries
2015-03-06 17:08 [PATCH] serial:8250:8250_pci: delete unneeded quirk entries Wang YanQing
@ 2015-03-06 21:21 ` Bryan O'Donoghue
2015-03-09 9:31 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Bryan O'Donoghue @ 2015-03-06 21:21 UTC (permalink / raw)
To: Wang YanQing, gregkh, linux-serial, linux-kernel
On 06/03/15 17:08, Wang YanQing wrote:
> These quirk entries have the same effect as default
> quirk entry, so we can just delete them.
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
ACK - does exactly what it says on the tin.
Tested-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] serial:8250:8250_pci: delete unneeded quirk entries
2015-03-06 21:21 ` Bryan O'Donoghue
@ 2015-03-09 9:31 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2015-03-09 9:31 UTC (permalink / raw)
To: Bryan O'Donoghue
Cc: Wang YanQing, Greg Kroah-Hartman, linux-serial,
linux-kernel@vger.kernel.org
On Fri, Mar 6, 2015 at 11:21 PM, Bryan O'Donoghue
<pure.logic@nexus-software.ie> wrote:
> On 06/03/15 17:08, Wang YanQing wrote:
>>
>> These quirk entries have the same effect as default
>> quirk entry, so we can just delete them.
>>
>> Signed-off-by: Wang YanQing <udknight@gmail.com>
>
>
> ACK - does exactly what it says on the tin.
>
> Tested-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Guys, the idea was as far as I remember to keep this placeholder to
introduce DMA support later.
Now it brought an additional effort to be done for that.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-09 9:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-06 17:08 [PATCH] serial:8250:8250_pci: delete unneeded quirk entries Wang YanQing
2015-03-06 21:21 ` Bryan O'Donoghue
2015-03-09 9:31 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox