From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932110AbbCFSVO (ORCPT ); Fri, 6 Mar 2015 13:21:14 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:52615 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754450AbbCFSVJ (ORCPT ); Fri, 6 Mar 2015 13:21:09 -0500 Date: Fri, 6 Mar 2015 10:21:02 -0800 From: Darren Hart To: Azael Avalos Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] toshiba_acpi: Add Hotkey Event Type function and definitions Message-ID: <20150306182102.GG19001@vmdeb7> References: <1424973434-3032-1-git-send-email-coproscefalo@gmail.com> <1424973434-3032-2-git-send-email-coproscefalo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424973434-3032-2-git-send-email-coproscefalo@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 26, 2015 at 10:57:12AM -0700, Azael Avalos wrote: Hi Azael, I'm pretty behind on this one, apologies. > This patch adds support to query the "Hotkey Event Type" the system > supports. > > There are two main event types (so far), 0x10 and 0x11, with the > first beign all those laptops that have the old keyboard layout, and being > the latter all those new laptops with the new keyboard layout. > Some concern about this binary "new" and "old". What happens in 2 years when they decide to break^W change our keyboards again? > Signed-off-by: Azael Avalos > --- > drivers/platform/x86/toshiba_acpi.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c > index dbcb7a8..e6aa8f9 100644 > --- a/drivers/platform/x86/toshiba_acpi.c > +++ b/drivers/platform/x86/toshiba_acpi.c > @@ -116,6 +116,7 @@ MODULE_LICENSE("GPL"); > #define HCI_KBD_ILLUMINATION 0x0095 > #define HCI_ECO_MODE 0x0097 > #define HCI_ACCELEROMETER2 0x00a6 > +#define HCI_HOTKEY_EVENT_TYPE 0xc000 > #define SCI_PANEL_POWER_ON 0x010d > #define SCI_ILLUMINATION 0x014e > #define SCI_USB_SLEEP_CHARGE 0x0150 > @@ -127,8 +128,11 @@ MODULE_LICENSE("GPL"); > > /* field definitions */ > #define HCI_ACCEL_MASK 0x7fff > +#define HCI_HOTKEY_EVENT_NORMAL 0x10 > +#define HCI_HOTKEY_EVENT_SPECIAL 0x11 NORMAL and SPECIAL? Hrm... what comes after special? EXTRASPECIAL? ;-) Or am I not looking at this right? Is there reason to expect these two to be sufficient? > #define HCI_HOTKEY_DISABLE 0x0b > #define HCI_HOTKEY_ENABLE 0x09 > +#define HCI_HOTKEY_ENABLE_SPECIAL 0x10 > #define HCI_LCD_BRIGHTNESS_BITS 3 > #define HCI_LCD_BRIGHTNESS_SHIFT (16-HCI_LCD_BRIGHTNESS_BITS) > #define HCI_LCD_BRIGHTNESS_LEVELS (1 << HCI_LCD_BRIGHTNESS_BITS) > @@ -1149,6 +1153,28 @@ static int toshiba_usb_three_set(struct toshiba_acpi_dev *dev, u32 state) > return 0; > } > > +/* Hotkey event type */ > +static int toshiba_hotkey_event_type_get(struct toshiba_acpi_dev *dev, > + u32 *hotkey_event_type) > +{ > + u32 val1 = 0x03; > + u32 val2 = 0; > + u32 result; > + > + result = hci_read2(dev, HCI_HOTKEY_EVENT_TYPE, &val1, &val2); > + if (result == TOS_FAILURE) { > + pr_err("ACPI callto get Hotkey Event type failed\n"); call to Thanks, -- Darren Hart Intel Open Source Technology Center