Re: [PATCH 3/3] toshiba_acpi: Fix the enabling of the Special Functions

Darren Hart
2015-03-19T03:58:22Z

On Fri, Mar 06, 2015 at 11:52:41AM -0700, Azael Avalos wrote:
> Hi Darren,
>
> 2015-03-06 11:28 GMT-07:00 Darren Hart <dvhart@infradead.org>:
> > On Thu, Feb 26, 2015 at 10:57:14AM -0700, Azael Avalos wrote:
> >> Some Toshiba laptops with the "Special Functions" feature enabled
> >> fail to properly enable such feature unless a specific value is
> >> used to enable the hotkey events.
> >
> > The specific value being... HCI_HOTKEY_ENABLE_SPECIAL? And we do this for ALL
> > systems that support special keys right (and have them enabled)? Not just the
> > ones that fail to properly enable them?
>
> For all of them supporting "special functions" and have them enabled.
>
> >
> > The above makes it sound like a work around, but nothing in the implementation
> > suggests that to me. Is this a workaround?
>
> This is more a fix than a workaround, on the laptops I tested this value
> is needed in order to properly activate the "special functions", if not,
> they will behave like "normal" even if the "special functions"are enabled.
>
> Tho' I'm not sure if it's only the models I tested or all of them, as I don't
> have that much hardware to test.

OK, I'll wait for v2 and queue for 4.1.

--
Darren Hart
Intel Open Source Technology Center