From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755802AbbCFSrG (ORCPT ); Fri, 6 Mar 2015 13:47:06 -0500 Received: from pmta1.delivery8.ore.mailhop.org ([54.191.158.99]:42331 "EHLO pmta1.delivery8.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755469AbbCFSrE (ORCPT ); Fri, 6 Mar 2015 13:47:04 -0500 X-Greylist: delayed 602 seconds by postgrey-1.27 at vger.kernel.org; Fri, 06 Mar 2015 13:47:04 EST X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX18PfME/Mbp1KmbHYQQ6uL1F Date: Fri, 6 Mar 2015 10:31:38 -0800 From: Tony Lindgren To: Valentin Rothberg Cc: akpm@linux-foundation.org, Jonathan Corbet , Ralf Baechle , David Woodhouse , Brian Norris , Greg Kroah-Hartman , Paul Bolle , Jiri Kosina , Hannes Reinecke , Ewan Milne , Christoph Hellwig , Hongliang Tao , Huacai Chen , Nishanth Menon , Peter Ujfalusi , Santosh Shilimkar , Rajendra Nayak , Afzal Mohammed , Keerthy , Sricharan R , Zhou Wang , Dan Carpenter , Felipe Balbi , Laurent Pinchart , Thomas Gleixner , Quentin Lambert , Arnd Bergmann , Ingo Molnar , Eyal Perry , Peter Zijlstra , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, iss_storagedev@hp.com, linux-mtd@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2] Remove deprecated IRQF_DISABLED flag entirely Message-ID: <20150306183137.GZ13520@atomide.com> References: <1425560442-13367-1-git-send-email-valentinrothberg@gmail.com> <1425565425-12604-1-git-send-email-valentinrothberg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425565425-12604-1-git-send-email-valentinrothberg@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Valentin Rothberg [150305 06:24]: > The IRQF_DISABLED is a NOOP and has been scheduled for removal since > Linux v2.6.36 by commit 6932bf37bed4 ("genirq: Remove IRQF_DISABLED from > core code"). > > According to commit e58aa3d2d0cc ("genirq: Run irq handlers with > interrupts disabled") running IRQ handlers with interrupts enabled can > cause stack overflows when the interrupt line of the issuing device is > still active. > > This patch ends the grace period for IRQF_DISABLED (i.e., SA_INTERRUPT > in older versions of Linux) and removes the definition and all remaining > usages of this flag. > > Signed-off-by: Valentin Rothberg Acked-by: Tony Lindgren