Re: [PATCH 03/15] twl4030_charger: use devres for power_supply_register and kzalloc.

Sebastian Reichel
2015-03-07T20:26:17Z

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

Hi,

On Tue, Feb 24, 2015 at 03:33:50PM +1100, NeilBrown wrote:
> [...]
> @@ -667,13 +667,6 @@ static int __init twl4030_bci_probe(struct platform_device *pdev)
> return 0;
>
> fail:
> - power_supply_unregister(&bci->usb);
> -fail_register_usb:
> - power_supply_unregister(&bci->ac);
> -fail_register_ac:
> -fail_no_battery:
> - kfree(bci);
> -
> return ret;
> }

Please replace "goto fail" with "return ret", goto is no
longer needed.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]