From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751400AbbCGBaz (ORCPT ); Fri, 6 Mar 2015 20:30:55 -0500 Received: from e34.co.us.ibm.com ([32.97.110.152]:45678 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbbCGBax (ORCPT ); Fri, 6 Mar 2015 20:30:53 -0500 Date: Fri, 6 Mar 2015 17:30:49 -0800 From: "Paul E. McKenney" To: Davidlohr Bueso Cc: Alexey Kodanev , josh@joshtriplett.org, linux-kernel@vger.kernel.org, vasily.isaenko@oracle.com Subject: Re: [PATCH] kernel/locking/locktorture: fix deadlock in 'rw_lock_irq' type Message-ID: <20150307013049.GJ5236@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1425686813-24029-1-git-send-email-alexey.kodanev@oracle.com> <20150307003742.GH5236@linux.vnet.ibm.com> <1425690180.19505.68.camel@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425690180.19505.68.camel@stgolabs.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15030701-0017-0000-0000-000009447B49 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 06, 2015 at 05:03:00PM -0800, Davidlohr Bueso wrote: > On Fri, 2015-03-06 at 16:37 -0800, Paul E. McKenney wrote: > > On Sat, Mar 07, 2015 at 03:06:53AM +0300, Alexey Kodanev wrote: > > > torture_rwlock_read_unlock_irq() must use read_unlock_irqrestore() > > > instead of write_unlock_irqrestore(). > > > > > > Use read_unlock_irqrestore() instead of write_unlock_irqrestore(). > > > > > > Signed-off-by: Alexey Kodanev > > > > Good catch! If Davidlohr has no objections, I will queue this one. > > Dear me, yes that looks completely borken. Thanks for the fix. Queued for v4.2. (If this is more urgent than that, please let me know.) Thanx, Paul