From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Oleg Nesterov <oleg@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>,
X86 ML <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: clean up unnecessarily wide TEST insns
Date: Sat, 7 Mar 2015 11:13:36 +0100 [thread overview]
Message-ID: <20150307101336.GA564@gmail.com> (raw)
In-Reply-To: <CALCETrXctXAp5hZWCj632hGt_EhXzh0KupD=GFrz7BHWDY80RA@mail.gmail.com>
* Andy Lutomirski <luto@amacapital.net> wrote:
> > +f6 c1 04 test $0x4,%cl
> > -48 f7 c1 08 00 00 00 test $0x8,%rcx
> > +f6 c1 08 test $0x8,%cl
> >
> > arch/x86/kernel/head_64.S | 2 +-
> > arch/x86/kernel/relocate_kernel_32.S | 8 ++++----
> > arch/x86/kernel/relocate_kernel_64.S | 8 ++++----
> > arch/x86/lib/checksum_32.S | 4 ++--
> > arch/x86/lib/csum-copy_64.S | 2 +-
>
> Looks good to me. Ingo, should I queue this up?
No need, I picked it up now that the 32-bit crash of tip:x86/asm is
fixed. I juiced up the changelog a bit. Will push it out after a bit
of testing.
Thanks,
Ingo
next prev parent reply other threads:[~2015-03-07 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 20:55 [PATCH] x86: clean up unnecessarily wide TEST insns Denys Vlasenko
2015-03-06 21:05 ` Andy Lutomirski
2015-03-07 10:13 ` Ingo Molnar [this message]
2015-03-06 22:24 ` Andi Kleen
2015-03-06 22:33 ` Andy Lutomirski
2015-03-06 22:37 ` Denys Vlasenko
2015-03-06 22:54 ` Linus Torvalds
2015-03-07 16:43 ` [tip:x86/asm] x86/asm: Optimize unnecessarily wide TEST instructions tip-bot for Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150307101336.GA564@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=dvlasenk@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=wad@chromium.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).