From: Mark Brown <broonie@kernel.org>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe
Date: Sat, 7 Mar 2015 10:59:48 +0000 [thread overview]
Message-ID: <20150307105948.GD28806@sirena.org.uk> (raw)
In-Reply-To: <1425655578-22400-2-git-send-email-iivanov@mm-sol.com>
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
On Fri, Mar 06, 2015 at 05:26:18PM +0200, Ivan T. Ivanov wrote:
> Ensure that driver is owner of the GPIO's used for CS signals.
> + for (cs = 0; cs < master->num_chipselect; cs++) {
> + cs_gpio = of_get_named_gpio(dev->of_node, "cs-gpios", cs);
> +
Any new GPIO users should really be using the gpiod API, however this is
duplicating core functionality so as Stephen says why are we doing this?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-03-07 10:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 15:26 [PATCH 1/2] spi: qup: Fix cs-num DT property parsing Ivan T. Ivanov
2015-03-06 15:26 ` [PATCH 2/2] spi: qup: Request CS GPIO's during probe Ivan T. Ivanov
2015-03-06 18:34 ` Stephen Boyd
2015-03-09 8:20 ` Ivan T. Ivanov
2015-03-09 18:53 ` Stephen Boyd
2015-03-10 8:31 ` Ivan T. Ivanov
2015-03-17 11:02 ` Ivan T. Ivanov
2015-03-07 10:59 ` Mark Brown [this message]
[not found] ` <1425889415.2440.10.camel@mm-sol.com>
[not found] ` <20150309182841.GW28806@sirena.org.uk>
2015-03-10 8:10 ` Ivan T. Ivanov
2015-03-10 11:06 ` Mark Brown
2015-03-10 12:53 ` Ivan T. Ivanov
2015-03-10 20:47 ` Mark Brown
2015-03-07 11:01 ` [PATCH 1/2] spi: qup: Fix cs-num DT property parsing Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150307105948.GD28806@sirena.org.uk \
--to=broonie@kernel.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox