From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751285AbbCGNOL (ORCPT <rfc822;w@1wt.eu>);
	Sat, 7 Mar 2015 08:14:11 -0500
Received: from mail-pa0-f49.google.com ([209.85.220.49]:33693 "EHLO
	mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750785AbbCGNOJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 7 Mar 2015 08:14:09 -0500
Date: Sat, 7 Mar 2015 18:43:56 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
        Andreas Dilger <andreas.dilger@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Luca Ceresoli <luca@lucaceresoli.net>,
        Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
        Heena Sirwani <heenasirwani@gmail.com>,
        Vitaly Osipov <vitaly.osipov@gmail.com>,
        Asaf Vertz <asaf.vertz@tandemg.com>,
        Himangi Saraogi <himangi774@gmail.com>,
        Greg Donald <gdonald@gmail.com>, Joe Perches <joe@perches.com>,
        HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/lustre: Make lstcon_console_{init,fini} static
Message-ID: <20150307131342.GA18224@sudip-PC>
References: <1425728466-9629-1-git-send-email-peter.senna@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1425728466-9629-1-git-send-email-peter.senna@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Mar 07, 2015 at 12:41:06PM +0100, Peter Senna Tschudin wrote:
> sparse was complaining that the symbols 'lstcon_console_init'
> and 'lstcon_console_fini' were not declared.
> 
> Declaring both as static.

you have not even build tested your patch.

WARNING: "lstcon_console_init" [drivers/staging/lustre/lnet/selftest/lnet_selftest.ko] undefined!
WARNING: "lstcon_console_fini" [drivers/staging/lustre/lnet/selftest/lnet_selftest.ko] undefined!

both of them are being used in selftest/module.c


regards
sudip
> 
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
>  drivers/staging/lustre/lnet/selftest/console.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c
> index 1e0afc2..6d62c48 100644
> --- a/drivers/staging/lustre/lnet/selftest/console.c
> +++ b/drivers/staging/lustre/lnet/selftest/console.c
> @@ -1989,8 +1989,7 @@ extern int lstcon_ioctl_entry(unsigned int cmd, struct libcfs_ioctl_data *data);
>  static DECLARE_IOCTL_HANDLER(lstcon_ioctl_handler, lstcon_ioctl_entry);
>  
>  /* initialize console */
> -int
> -lstcon_console_init(void)
> +static int lstcon_console_init(void)
>  {
>  	int     i;
>  	int     rc;
> @@ -2059,8 +2058,7 @@ out:
>  	return rc;
>  }
>  
> -int
> -lstcon_console_fini(void)
> +static int lstcon_console_fini(void)
>  {
>  	int     i;
>  
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/