Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

Jiri Kosina
2015-03-04T15:54:38Z

On Wed, 4 Mar 2015, Borislav Petkov wrote:

> On Wed, Mar 04, 2015 at 12:00:37AM -0800, Yinghai Lu wrote:
> > commit f47233c2d34f ("x86/mm/ASLR: Propagate base load address calculation")
> > is using address as value for kaslr_enabled.
> >
> > That will random kaslr_enabled get that set or cleared.
> > Will have problem for system really have kaslr enabled.
> >
> > -v2: update changelog.
>
> This is still not good enough. Please do this:
>
> In commit f47233c2d34f we did A. The problem with that is B. Change the
> code to do C.
>
> Now you only have to fill out the A,B and C variables with the
> respective text which is understandable even for people who don't know
> this code.

Also this 15-patch series needs to be separated into two patchsets. The
whole series is not appropriate for -rc3, but this particular one at least
is a regression fix that has to go in.

Thanks,

--
Jiri Kosina
SUSE Labs