Re: [PATCH v2 01/15] x86, kaslr: Use init_size instead of run_size

Borislav Petkov
2015-03-06T13:56:56Z

On Wed, Mar 04, 2015 at 12:00:34AM -0800, Yinghai Lu wrote:
> commit e6023367d779 ("x86, kaslr: Prevent .bss from overlaping initrd")
>
> introduced one run_size for kaslr.
>
> We do not need to have home grown run_size.
>
> We should use real runtime size (include copy/decompress) aka init_size

Why?

I can see why but you need to explain it here. Also, look at the
e6023367d779 commit message. Now this is how you do a commit message!
Especially if it is early boot code, you explain stuff. Junjie even went
the distance and did a nice graphic.

So please redo your commit message.

And saying it is trivial and obvious will not get you anywhere, as
you've noticed already.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--