From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752970AbbCGVIv (ORCPT ); Sat, 7 Mar 2015 16:08:51 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:52593 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752907AbbCGVIs (ORCPT ); Sat, 7 Mar 2015 16:08:48 -0500 Date: Sat, 7 Mar 2015 21:08:46 +0000 From: Al Viro To: Linus Torvalds Cc: Linux Kernel Mailing List , "J. Bruce Fields" Subject: [PATCH] sunrpc: fix braino in ->poll() Message-ID: <20150307210846.GF29656@ZenIV.linux.org.uk> References: <20150305154921.GZ29656@ZenIV.linux.org.uk> <20150307204405.GC29656@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org POLL_OUT isn't what callers of ->poll() are expecting to see; it's actually __SI_POLL | 2 and it's a siginfo code, not a poll bitmap bit... Signed-off-by: Al Viro --- diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c index 33fb105..5199bb1 100644 --- a/net/sunrpc/cache.c +++ b/net/sunrpc/cache.c @@ -921,7 +921,7 @@ static unsigned int cache_poll(struct file *filp, poll_table *wait, poll_wait(filp, &queue_wait, wait); /* alway allow write */ - mask = POLL_OUT | POLLWRNORM; + mask = POLLOUT | POLLWRNORM; if (!rp) return mask;