From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751683AbbCHEOm (ORCPT ); Sat, 7 Mar 2015 23:14:42 -0500 Received: from mail-ig0-f178.google.com ([209.85.213.178]:34041 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbbCHEOj (ORCPT ); Sat, 7 Mar 2015 23:14:39 -0500 Date: Sat, 7 Mar 2015 20:14:34 -0800 From: Dmitry Torokhov To: Mathias Gottschlag Cc: Hans de Goede , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 3/4] psmouse: Disable resolution/rate/scale changes for FocalTech touchpads. Message-ID: <20150308041434.GA1482@dtor-ws> References: <1423940502-12353-1-git-send-email-mgottschlag@gmail.com> <1424992808-29891-1-git-send-email-mgottschlag@gmail.com> <1424992808-29891-4-git-send-email-mgottschlag@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424992808-29891-4-git-send-email-mgottschlag@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mathias, On Fri, Feb 27, 2015 at 12:20:07AM +0100, Mathias Gottschlag wrote: > These PS/2 commands make some touchpads stop responding, so this commit > adds some dummy functions to replace the generic implementation. Because > @@ -60,6 +65,7 @@ struct psmouse { > > unsigned int rate; > unsigned int resolution; > + enum psmouse_scale scale; > unsigned int resetafter; > unsigned int resync_time; > bool smartscroll; /* Logitech only */ I do not believe we need to store the scaling factor so I dropped these chunks, otherwise applied all 4. Thanks. -- Dmitry