From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbbCHM7O (ORCPT ); Sun, 8 Mar 2015 08:59:14 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:36039 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752458AbbCHM7K (ORCPT ); Sun, 8 Mar 2015 08:59:10 -0400 Date: Sun, 8 Mar 2015 18:28:59 +0530 From: Sudip Mukherjee To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] staging: sm750fb: wrong type for print Message-ID: <20150308125859.GA14649@sudip-PC> References: <1425817886-14387-1-git-send-email-sudipm.mukherjee@gmail.com> <54FC4323.3010909@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54FC4323.3010909@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 08, 2015 at 02:40:03PM +0200, Giedrius Statkevičius wrote: > On 2015.03.08 14:31, Sudip Mukherjee wrote: > > mention correct format specifier while printing > > index 711676c..2ab7b74 100644 > > --- a/drivers/staging/sm750fb/sm750.h > > +++ b/drivers/staging/sm750fb/sm750.h > > @@ -59,10 +59,10 @@ struct lynx_share{ > > }mtrr; > > #endif > > /* all smi graphic adaptor got below attributes */ > > - resource_size_t vidmem_start; > > - resource_size_t vidreg_start; > > - resource_size_t vidmem_size; > > - resource_size_t vidreg_size; > > + unsigned long vidmem_start; > > + unsigned long vidreg_start; > > + unsigned long vidmem_size; > > + unsigned long vidreg_size; > > Have you checked other places where these are used? resource_size_t can > be either u64 or u32 depending on if CONFIG_PHYS_ADDR_T_64BIT is > #defined. Are you sure you aren't losing information when results of > functions are being assigned to this? Maybe there should be a function > similar to printk that changes between %u and %llu depending on whether > that is defined? oops .. no .. :( i checked in other framebuffer drivers and saw they are mostly unsigned long. I will check further on this. Greg: can you please drop this patch (1/4) from your queue and not apply this to your tree. I will send it as a v2. regards sudip > > -- > Thanks, > Giedrius