From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: "Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] staging: sm750fb: correctly define SM750LE_REVISION_ID
Date: Sun, 8 Mar 2015 23:01:47 +0530 [thread overview]
Message-ID: <20150308173147.GA15272@sudip-PC> (raw)
In-Reply-To: <54FC4797.6040704@gmail.com>
On Sun, Mar 08, 2015 at 02:59:03PM +0200, Giedrius Statkevičius wrote:
> On 2015.03.08 14:31, Sudip Mukherjee wrote:
> > -#define SM750LE_REVISION_ID (char)0xfe
> > +#ifndef SM750LE_REVISION_ID
> > +#define SM750LE_REVISION_ID ((unsigned char)0xfe)
> > +#endif
>
> Do you need these parantheses? Also, you can now then fix up this line
> too to avoid a redundant cast in the same patch:
> sm750_hw.c: if(share->revid == (unsigned char)SM750LE_REVISION_ID){
good idea, thanks.
that extra parentheses is for checkpatch warning of complex macro value.
i will better send a v2 of the whole series after checking that resource_size_t.
regards
sudip
>
>
> --
> Thanks,
> Giedrius
next prev parent reply other threads:[~2015-03-08 17:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 12:31 [PATCH 1/4] staging: sm750fb: wrong type for print Sudip Mukherjee
2015-03-08 12:31 ` [PATCH 2/4] staging: sm750fb: remove pragma optimize Sudip Mukherjee
2015-03-08 12:31 ` [PATCH 3/4] staging: sm750fb: correctly define SM750LE_REVISION_ID Sudip Mukherjee
2015-03-08 12:59 ` Giedrius Statkevičius
2015-03-08 17:31 ` Sudip Mukherjee [this message]
2015-03-08 12:31 ` [PATCH 4/4] staging: sm750fb: fix undeclared function Sudip Mukherjee
2015-03-08 13:02 ` Giedrius Statkevičius
2015-03-08 12:40 ` [PATCH 1/4] staging: sm750fb: wrong type for print Giedrius Statkevičius
2015-03-08 12:58 ` Sudip Mukherjee
2015-03-09 9:22 ` Dan Carpenter
2015-03-09 9:35 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150308173147.GA15272@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=giedrius.statkevicius@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox