From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753114AbbCHRcB (ORCPT ); Sun, 8 Mar 2015 13:32:01 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:46131 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752936AbbCHRb7 (ORCPT ); Sun, 8 Mar 2015 13:31:59 -0400 Date: Sun, 8 Mar 2015 23:01:47 +0530 From: Sudip Mukherjee To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] staging: sm750fb: correctly define SM750LE_REVISION_ID Message-ID: <20150308173147.GA15272@sudip-PC> References: <1425817886-14387-1-git-send-email-sudipm.mukherjee@gmail.com> <1425817886-14387-3-git-send-email-sudipm.mukherjee@gmail.com> <54FC4797.6040704@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54FC4797.6040704@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 08, 2015 at 02:59:03PM +0200, Giedrius Statkevičius wrote: > On 2015.03.08 14:31, Sudip Mukherjee wrote: > > -#define SM750LE_REVISION_ID (char)0xfe > > +#ifndef SM750LE_REVISION_ID > > +#define SM750LE_REVISION_ID ((unsigned char)0xfe) > > +#endif > > Do you need these parantheses? Also, you can now then fix up this line > too to avoid a redundant cast in the same patch: > sm750_hw.c: if(share->revid == (unsigned char)SM750LE_REVISION_ID){ good idea, thanks. that extra parentheses is for checkpatch warning of complex macro value. i will better send a v2 of the whole series after checking that resource_size_t. regards sudip > > > -- > Thanks, > Giedrius