From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752627AbbCHUBu (ORCPT ); Sun, 8 Mar 2015 16:01:50 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59082 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429AbbCHUBr (ORCPT ); Sun, 8 Mar 2015 16:01:47 -0400 Date: Sun, 8 Mar 2015 20:01:42 +0000 From: Mark Brown To: "Ivan T. Ivanov" Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Message-ID: <20150308200142.GC28806@sirena.org.uk> References: <1425656716-25363-1-git-send-email-iivanov@mm-sol.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="POjlveFHrWq2ZO+N" Content-Disposition: inline In-Reply-To: <1425656716-25363-1-git-send-email-iivanov@mm-sol.com> X-Cookie: Editing is a rewording activity. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH] spi: Ensure that CS line is in non-active state after setup X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --POjlveFHrWq2ZO+N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 06, 2015 at 05:45:15PM +0200, Ivan T. Ivanov wrote: > if (spi->master->setup) > status = spi->master->setup(spi); > + else > + spi_set_cs(spi, false); Why would this be conditional on there not being a setup operation? It's a good idea, I just don't see why the backstop isn't always useful. --POjlveFHrWq2ZO+N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJU/KqlAAoJECTWi3JdVIfQsskH/A38qRARBQUjZgLdzjYCw0Wt Xq2uLxMlmtv330Vcjoo/sNdhnGfGPTwb819Rlmd+Ozse29lpwjP7KU9yFTJOS7Mv Ot9nlZuHKYqvNi47ik7hkTNcXEo3QyQoh2DClf2eTbobHRTc0atdP2WaYvadncQW pB4WH3Fs8n0gXWsFanht/Wdlgm/iyJ5TEOapLr6E7nGp374mS/lXQMfhKKEtncYE SNjNOxz9QM8HbwoBvXYLrivnZLGhFK2vGcMUyMUfd419m1CFBp5aoNjOqu1DK07Y 8T9ODWetxJbEn9PTBqQO7/5soXgbjIoPVjcqGLx7GfiEh1vv6nJT81ANzq+0tOo= =oLXW -----END PGP SIGNATURE----- --POjlveFHrWq2ZO+N--