From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753223AbbCIBWz (ORCPT ); Sun, 8 Mar 2015 21:22:55 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:18564 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbbCIBWw (ORCPT ); Sun, 8 Mar 2015 21:22:52 -0400 X-AuditID: cbfee68d-f79296d000004278-c4-54fcf5e90bc4 Date: Mon, 09 Mar 2015 10:21:44 +0900 From: Changman Lee To: Yuan Zhong Cc: Jaegeuk Kim , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" Subject: Re: [f2fs-dev] [PATCH 1/3] f2fs:remove unnecessary condition judgment Message-id: <20150309012144.GB4450@lcm-devel.org> References: <300031252.458581425722724194.JavaMail.weblogic@epmlwas08b> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <300031252.458581425722724194.JavaMail.weblogic@epmlwas08b> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMIsWRmVeSWpSXmKPExsVy+t8zY91XX/+EGDz2sHiyfhazxaVF7hZ7 9p5ksbi8aw6bxZ9NnUwOrB6bVnWyeexe8JnJo2/LKkaPz5vkAliiuGxSUnMyy1KL9O0SuDIm XvzEVPCOp6Lh5TXmBsadXF2MnBwSAiYSbTsnMkLYYhIX7q1n62Lk4hASWMYosfvCEXaYonX7 N7BAJBYxSqyc+Z4JwvnJKLGi4RkrSBWLgKrEijV/2UBsNgEtifbTa1lAbBEBHYlN044yg9jM Av8ZJb5tsQWxhQX8JM5dXskEYvMKGErs+LEYzBYScJfYvfAZG0RcUOLH5HssEL1aEut3HmeC sKUlHv2dAXYdp4CHxLxb68FqRAVUJKac3Ab2goTANnaJTY+XMUEcJyDxbfIhoCIOoISsxKYD zBCfSUocXHGDZQKj2Cwk62YhWTcLyboFjMyrGEVTC5ILipPSiwz1ihNzi0vz0vWS83M3MULi qncH4+0D1ocYBTgYlXh4d5z4EyLEmlhWXJl7iNEU6IqJzFKiyfnA6M0riTc0NjOyMDUxNTYy tzRTEudVlPoZLCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoFxVdO5q7GL7792eiQt9u9/fKf7 Kh2jpdxRy+88z2pTb4tWbrio8jpU4uDB0iOTK0qajddNF/vgz9S09cik3HvacxY3Pnvo5XvC ckqgoHUd56yFpayaCp+tSiwftVQvnV70/kNsxtQz967vXj4jq95N8bHZKUPHeGWZUiMDV/sd nRqzetSsN6sosRRnJBpqMRcVJwIAdVtPhqYCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsVy+t9jAd2XX/+EGPx/ZmnxZP0sZotLi9wt 9uw9yWJxedccNos/mzqZHFg9Nq3qZPPYveAzk0ffllWMHp83yQWwRDUw2mSkJqakFimk5iXn p2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYA7VVSKEvMKQUKBSQWFyvp22Ga EBripmsB0xih6xsSBNdjZIAGEtYxZky8+Imp4B1PRcPLa8wNjDu5uhg5OSQETCTW7d/AAmGL SVy4t56ti5GLQ0hgEaPEypnvmSCcn4wSKxqesYJUsQioSqxY85cNxGYT0JJoP70WrFtEQEdi 07SjzCA2s8B/RolvW2xBbGEBP4lzl1cygdi8AoYSO34sBrOFBNwldi98xgYRF5T4MfkeC0Sv lsT6nceZIGxpiUd/Z7CD2JwCHhLzbq0HqxEVUJGYcnIb2wRGgVlI2mchaZ+FpH0BI/MqRtHU guSC4qT0XCO94sTc4tK8dL3k/NxNjOC4fSa9g3FVg8UhRgEORiUe3h0n/oQIsSaWFVfmHmKU 4GBWEuEVPQkU4k1JrKxKLcqPLyrNSS0+xGgKDI2JzFKiyfnAlJJXEm9obGJmZGlkZmFkYm6u JM6rZN8WIiSQnliSmp2aWpBaBNPHxMEp1cAoEP2K03Ry9PSN1ZxuYqdXSdfmCWy+Jl1XU+Dy Y/etJdvv3OS4FnBYjvGj1+dch/wFgnyhAQ7Lmuczb0r+sX1W5+pM1ouTbi+4suH2gb0tCi8m hRYo/dt1q+He82N7ZM5Fft+z8yZ34dOnK8pDlsV+l3+8sJl50peiriWveyP/eJhdW3Zex2yq lBJLcUaioRZzUXEiABa4ymHxAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yuan, On Sat, Mar 07, 2015 at 10:05:25AM +0000, Yuan Zhong wrote: > Remove the unnecessary condition judgment, because > 'max_slots' has been initialized to '0' at the beginging > of the function, as following: > if (max_slots) > max_len = 0; There is wrong statement. It should be fixed as *max_slot = 0. Thanks, > > Signed-off-by: Yuan Zhong > --- > fs/f2fs/dir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c > index 590aeef..1f1a1bc 100644 > --- a/fs/f2fs/dir.c > +++ b/fs/f2fs/dir.c > @@ -139,7 +139,7 @@ struct f2fs_dir_entry *find_target_dentry(struct qstr *name, int *max_slots, > !memcmp(d->filename[bit_pos], name->name, name->len)) > goto found; > > - if (max_slots && *max_slots >= 0 && max_len > *max_slots) { > + if (max_slots && max_len > *max_slots) { > *max_slots = max_len; > max_len = 0; > } > -- > 1.7.9.5 > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming The Go Parallel Website, sponsored > by Intel and developed in partnership with Slashdot Media, is your hub for all > things parallel software development, from weekly thought leadership blogs to > news, videos, case studies, tutorials and more. Take a look and join the > conversation now. http://goparallel.sourceforge.net/ > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel