From: Greg KH <gregkh@linuxfoundation.org>
To: Zhang Zhen <zhenzhang.zhang@huawei.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
tim.kryger@linaro.org, jamie@jamieiles.com, alan@linux.intel.com,
arnd@arndb.de
Subject: Re: [PATCH] serial: 8250: fix a sparse warning
Date: Mon, 9 Mar 2015 09:22:53 +0100 [thread overview]
Message-ID: <20150309082253.GA14349@kroah.com> (raw)
In-Reply-To: <54FD4EE6.7000408@huawei.com>
On Mon, Mar 09, 2015 at 03:42:30PM +0800, Zhang Zhen wrote:
> drivers/tty/serial/8250/8250_core.c: In function ‘serial8250_console_write’:
> drivers/tty/serial/8250/8250_core.c:3244: warning: ‘flags’ may be used u
> unitialized in this function
>
> Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>
> ---
> drivers/tty/serial/8250/8250_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index deae122..50702e2 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -3241,7 +3241,7 @@ serial8250_console_write(struct console *co, const char *s, unsigned int count)
> {
> struct uart_8250_port *up = &serial8250_ports[co->index];
> struct uart_port *port = &up->port;
> - unsigned long flags;
> + unsigned long flags = 0;
> unsigned int ier;
> int locked = 1;
>
Sparse generated this? Or did a broken / old version of gcc?
This patch fixes nothing, sorry, so I can't accept it.
greg k-h
next prev parent reply other threads:[~2015-03-09 8:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1425886615-78601-1-git-send-email-zhenzhang.zhang@huawei.com>
2015-03-09 7:42 ` [PATCH] serial: 8250: fix a sparse warning Zhang Zhen
2015-03-09 8:22 ` Greg KH [this message]
2015-03-09 8:41 ` Zhang Zhen
2015-03-09 8:53 ` Greg KH
2015-03-09 9:02 ` Zhang Zhen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309082253.GA14349@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=jamie@jamieiles.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tim.kryger@linaro.org \
--cc=zhenzhang.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox